From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44262 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OMFif-0007cP-Rv
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:29:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OMFiH-0001v2-Aa
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:28:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54536)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OMFiH-0001uu-3u
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:28:37 -0400
Message-ID: <4C0F4294.6070105@redhat.com>
Date: Wed, 09 Jun 2010 09:28:20 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field
References: <20100608191447.4451.47795.stgit@localhost.localdomain>	<20100608191557.4451.30384.stgit@localhost.localdomain>
	<201006090330.10324.paul@codesourcery.com>
	<4C0EFF39.9070602@codemonkey.ws>
In-Reply-To: <4C0EFF39.9070602@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: chrisw@redhat.com, kvm@vger.kernel.org, quintela@redhat.com, qemu-devel@nongnu.org, Alex Williamson <alex.williamson@redhat.com>, Paul Brook <paul@codesourcery.com>

On 06/09/10 04:40, Anthony Liguori wrote:
> On 06/08/2010 09:30 PM, Paul Brook wrote:
>>> The offset given to a block created via qemu_ram_alloc/map() is
>>> arbitrary,
>>> let the caller specify a name so we can make a positive match.
>>> @@ -1924,7 +1925,9 @@ static int pci_add_option_rom(PCIDevice *pdev)
>>> + snprintf(name, sizeof(name), "pci:%02x.%x.rom",
>>> + PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
>>> + pdev->rom_offset = qemu_ram_alloc(name, size);
>> This looks pretty bogus. It should be associated with the device,
>> rather than
>> incorrectly trying to generate a globally unique name.
>
> Not all ram is associated with a device.

Nevertheless qdev could carry a list of any device specific ram, so 
qdev_free() could automagically cleanup for you on unplug.  You could 
also reuse DeviceState->info->vmsd->name for the ram section naming.

cheers,
   Gerd