From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33850 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMG4p-0008FJ-UZ for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:52:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMG4o-0006Kg-Pt for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:51:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36617) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMG4o-0006Ka-IV for qemu-devel@nongnu.org; Wed, 09 Jun 2010 03:51:54 -0400 Message-ID: <4C0F4815.2050306@redhat.com> Date: Wed, 09 Jun 2010 09:51:49 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 21/22] machine: convert pc machines to split core vs machine API References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com> <1275954730-8196-22-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1275954730-8196-22-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Glauber Costa , qemu-devel@nongnu.org On 06/08/10 01:52, Anthony Liguori wrote: > +static QemuOptValue pc_machine_v0_11[] = { > + QOPT_VALUE("name", "pc-0.11"), > + QOPT_VALUE("desc", "Standard PC, qemu 0.11"), > + QOPT_VALUE("acpi", "on"), > + QOPT_VALUE("pci", "on"), > + QOPT_VALUE("cpu", PC_DEFAULT_CPU_MODEL), > + QOPT_VALUE("max_cpus", "255"), > + QOPT_COMPAT_INT("virtio-blk-pci", "vectors", 0), > + QOPT_COMPAT_INT("virtio-serial-pci", "max_nr_ports", 1), > + QOPT_COMPAT_INT("virtio-serial-pci", "vectors", 0), > + QOPT_COMPAT("ide-drive", "ver", "0.11"), > + QOPT_COMPAT("scsi-disk", "ver", "0.11"), > + QOPT_COMPAT_INT("PCI", "rombar", 0), > + { /* end of list */ } > }; For v11 and older, you might want to change max_cpus to what the BIOS we supported back then actually was able to run with, ie. 15. Cheers, Jes