From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code
Date: Wed, 09 Jun 2010 10:14:19 +0200 [thread overview]
Message-ID: <4C0F4D5B.9070806@redhat.com> (raw)
In-Reply-To: <m3y6eo65vi.fsf@blackfin.pond.sub.org>
On 06/09/10 09:07, Markus Armbruster wrote:
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>> On 06/04/10 13:54, Markus Armbruster wrote:
>> If there is strong feeling we should do it this way instead, I can
>> change the code to do it this way instead. I am not married to the
>> current approach, I just find it the lesser evil.
>
> I'm making suggestions, not demands. If you still prefer your way after
> considering my suggestions, go with it.
>
> For what it's worth, pushing OS-dependent bits out of the option parsing
> allows for:
>
> qemu: --frobnicate: Can't frobnicate under Windows
>
> instead of
>
> qemu: --frobnicate: invalid option
That is true, on the other hand I think it would be cleaner to not
advertise options on an OS where it is not supported. Ideally I would
like them to not show up in qemu --help at all.
Cheers,
Jes
prev parent reply other threads:[~2010-06-09 8:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 16:47 [Qemu-devel] [PATCH 00/16] clean up vl.c code Jes.Sorensen
2010-06-03 16:47 ` [Qemu-devel] [PATCH 01/16] vl.c: Remove double include of netinet/in.h for Solaris Jes.Sorensen
2010-06-03 16:47 ` [Qemu-devel] [PATCH 02/16] Create qemu-os-win32.h and move WIN32 specific declarations there Jes.Sorensen
2010-06-03 16:47 ` [Qemu-devel] [PATCH 03/16] Introduce os-win32.c and move polling functions from vl.c Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 04/16] vl.c: Move host_main_loop_wait() to OS specific files Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 05/16] Introduce os-posix.c and create os_setup_signal_handling() Jes.Sorensen
2010-06-03 20:50 ` Richard Henderson
2010-06-04 6:45 ` Jes Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 06/16] Move win32 early signal handling setup to os_setup_signal_handling() Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 07/16] Rename os_setup_signal_handling() to os_setup_early_signal_handling() Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 08/16] Move main signal handler setup to os specificfiles Jes.Sorensen
2010-06-03 20:52 ` Richard Henderson
2010-06-04 6:45 ` Jes Sorensen
2010-06-04 7:45 ` Markus Armbruster
2010-06-03 16:48 ` [Qemu-devel] [PATCH 09/16] Move find_datadir to OS specific files Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c Jes.Sorensen
2010-06-03 20:58 ` Richard Henderson
2010-06-04 6:47 ` Jes Sorensen
2010-06-04 14:49 ` Richard Henderson
2010-06-04 14:51 ` Jes Sorensen
2010-06-04 8:15 ` Markus Armbruster
2010-06-04 8:21 ` Jes Sorensen
2010-06-04 10:39 ` [Qemu-devel] " Paolo Bonzini
2010-06-04 11:59 ` Jes Sorensen
2010-06-04 12:04 ` [Qemu-devel] " Markus Armbruster
2010-06-04 12:11 ` Jes Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 11/16] Move runas handling from vl.c to OS specific files Jes.Sorensen
2010-06-03 21:00 ` Richard Henderson
2010-06-03 16:48 ` [Qemu-devel] [PATCH 12/16] Move chroot handling " Jes.Sorensen
2010-06-03 21:02 ` Richard Henderson
2010-06-04 6:48 ` Jes Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 13/16] Move daemonize " Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 14/16] Make os_change_process_uid and os_change_root os-posix.c local Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 15/16] Move line-buffering setup to OS specific files Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 16/16] Move set_proc_name() " Jes.Sorensen
2010-06-04 8:21 ` [Qemu-devel] [PATCH 00/16] clean up vl.c code Markus Armbruster
2010-06-04 8:23 ` Jes Sorensen
2010-06-04 11:54 ` Markus Armbruster
2010-06-04 11:57 ` Jes Sorensen
2010-06-09 7:07 ` Markus Armbruster
2010-06-09 8:14 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0F4D5B.9070806@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).