From: Gerd Hoffmann <kraxel@redhat.com>
To: Marcos Oviedo <moviedo.maillist@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command
Date: Wed, 09 Jun 2010 16:27:05 +0200 [thread overview]
Message-ID: <4C0FA4B9.7090906@redhat.com> (raw)
In-Reply-To: <AANLkTikxXDikl-mG-jnFiTc57HYcehx1s8R5yISgeDA5@mail.gmail.com>
Hi,
> This make sense when you mistakenly add a pci device on a -s -S
> scenario, like the scenario described on the following bug:
> https://bugs.launchpad.net/qemu/+bug/544367.
It doesn't IMHO.
> When ACPI-based hotplug support is present on the guest and we run
> pci_del with the force option, the hotplug events will still be
> generated to the guest and the guest still will trigger the EJx event,
> which will end by calling pciej_write() on qemu side. This function will
> do nothing on a -f and pci hotplug support scenario, as the pci device
> was previously removed by pci_del.
And in case the guest wants to do anything (like flushing dirty buffers)
before triggering the EJx event it will horribly fail.
If the guest is stopped while unplugging the device the unplug should
happen as soon as the guest is unpaused.
cheers,
Gerd
next prev parent reply other threads:[~2010-06-09 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 5:37 [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command Marcos Oviedo
2010-06-09 6:39 ` Markus Armbruster
2010-06-09 7:38 ` Gerd Hoffmann
2010-06-09 14:00 ` Marcos Oviedo
2010-06-09 14:27 ` Gerd Hoffmann [this message]
2010-06-14 16:59 ` Anthony Liguori
2010-06-15 8:46 ` Gerd Hoffmann
2010-06-15 9:03 ` Markus Armbruster
2010-06-17 18:15 ` Luiz Capitulino
2010-06-17 18:20 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0FA4B9.7090906@redhat.com \
--to=kraxel@redhat.com \
--cc=moviedo.maillist@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).