From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37299 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMMFo-0001iw-Jv for qemu-devel@nongnu.org; Wed, 09 Jun 2010 10:27:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMMFL-0004Ld-Ob for qemu-devel@nongnu.org; Wed, 09 Jun 2010 10:27:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43963) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMMFL-0004LW-Gi for qemu-devel@nongnu.org; Wed, 09 Jun 2010 10:27:11 -0400 Message-ID: <4C0FA4B9.7090906@redhat.com> Date: Wed, 09 Jun 2010 16:27:05 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command References: <4C0F450B.5000802@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcos Oviedo Cc: qemu-devel@nongnu.org Hi, > This make sense when you mistakenly add a pci device on a -s -S > scenario, like the scenario described on the following bug: > https://bugs.launchpad.net/qemu/+bug/544367. It doesn't IMHO. > When ACPI-based hotplug support is present on the guest and we run > pci_del with the force option, the hotplug events will still be > generated to the guest and the guest still will trigger the EJx event, > which will end by calling pciej_write() on qemu side. This function will > do nothing on a -f and pci hotplug support scenario, as the pci device > was previously removed by pci_del. And in case the guest wants to do anything (like flushing dirty buffers) before triggering the EJx event it will horribly fail. If the guest is stopped while unplugging the device the unplug should happen as soon as the guest is unpaused. cheers, Gerd