From: Anthony Liguori <anthony@codemonkey.ws>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Chris Wright <chrisw@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, armbru@redhat.com
Subject: Re: [Qemu-devel] Re: KVM call minutes for June 8
Date: Wed, 09 Jun 2010 11:26:35 -0500 [thread overview]
Message-ID: <4C0FC0BB.7060806@codemonkey.ws> (raw)
In-Reply-To: <20100609121820.1f3bb47a@redhat.com>
On 06/09/2010 10:18 AM, Luiz Capitulino wrote:
>> The big problem is things like the block io error events. I don't see
>> how we can support that given what we have in 0.13. Putting errno on
>> the wire is a bad idea. We need to marshal a QError object using the
>> __class__ memory to identify it as QError and pass that with the event.
>> It could potentially be made to work for 0.13 but it'll be ugly.
>>
> Yes, that's the main problem of the whole thing I think.
>
> From QEMU pov, the best thing to do would be to let this event as it's
> today and wait for the new QError (it's a compatible change, anyway).
>
I'd prefer that we just send the event with an embedded qerror (using
__class__). We can generate it directly instead of using
qerror_report/qerror_new. It's ugly but it'll work and be future
compatible. For now, let's just support a few types of qerror to
basically distinguish between an unknown io error and ENOSPC.
> However, libvirt was counting on this feature and on the snapshot commands
> to switch from the text Monitor. We have two options:
>
I don't think snapshots are actually usable by libvirt in the current form.
Regards,
Anthony LIguori
> 1. Ask them to wait one more release (not so good for us)
> 2. Try to find a way to have those features in for 0.13
>
> Daniel has commented to me that making the snapshot commands synchronous
> for 0.13 wouldn't be that bad, what do you think?
>
prev parent reply other threads:[~2010-06-09 16:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 15:05 [Qemu-devel] KVM call minutes for June 8 Chris Wright
2010-06-08 16:01 ` [Qemu-devel] " Anthony Liguori
2010-06-08 20:59 ` Luiz Capitulino
2010-06-08 21:13 ` Anthony Liguori
2010-06-09 15:18 ` Luiz Capitulino
2010-06-09 15:31 ` Daniel P. Berrange
2010-06-09 16:22 ` Anthony Liguori
2010-06-09 16:29 ` Daniel P. Berrange
2010-06-10 9:43 ` Kevin Wolf
2010-06-10 12:53 ` Anthony Liguori
2010-06-10 13:08 ` Kevin Wolf
2010-06-10 14:11 ` Avi Kivity
2010-06-10 14:22 ` Kevin Wolf
2010-06-10 14:27 ` Anthony Liguori
2010-06-11 12:55 ` Luiz Capitulino
2010-06-11 13:48 ` Anthony Liguori
2010-06-09 16:26 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0FC0BB.7060806@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=chrisw@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).