From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37149 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMzus-0007k7-Sr for qemu-devel@nongnu.org; Fri, 11 Jun 2010 04:48:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMzur-0006Dl-LB for qemu-devel@nongnu.org; Fri, 11 Jun 2010 04:48:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6201) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMzur-0006Dd-EZ for qemu-devel@nongnu.org; Fri, 11 Jun 2010 04:48:41 -0400 Message-ID: <4C11F858.4050904@redhat.com> Date: Fri, 11 Jun 2010 10:48:24 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field References: <20100608191447.4451.47795.stgit@localhost.localdomain> <4C10A106.1050108@redhat.com> <1276180408.2992.12.camel@x201> <201006101549.14094.paul@codesourcery.com> <1276183304.3100.9.camel@x201> In-Reply-To: <1276183304.3100.9.camel@x201> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: chrisw@redhat.com, kvm@vger.kernel.org, quintela@redhat.com, qemu-devel@nongnu.org, Paul Brook On 06/10/10 17:21, Alex Williamson wrote: > On Thu, 2010-06-10 at 15:49 +0100, Paul Brook wrote: >>> Ok, we can certainly doname>.instance>\. >>> It seems like this highlights a deficiency in the vmstate matching >> >> Why are you forcing this to be a string? > > It seemed like a good way to send an identifier. What do you suggest? Do it the same way savevm handles device state? I think it simply puts a u32 for the instance id. cheers, Gerd