From: Prerna Saxena <prerna@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm@vger.kernel.org, Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, maneesh@linux.vnet.ibm.com,
ananth@linux.vnet.ibm.com, Jan@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/3] export tdb_hash()
Date: Fri, 11 Jun 2010 16:02:23 +0530 [thread overview]
Message-ID: <4C1210B7.7090703@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100609173506.454225c7@redhat.com>
On 06/10/2010 02:05 AM, Luiz Capitulino wrote:
> On Tue, 8 Jun 2010 12:31:38 +0530
> Prerna Saxena<prerna@linux.vnet.ibm.com> wrote:
>
>> This exports tdb_hash() for use by tracing framework.
>
> Suggest to rename it (eg. qemu_hash()) and move it to a better location, qdict
> is not the best module to export such service.
>
Would 'qemu-common.h' be a good place to export it ? If not, any
suggestions on where else I can export it ?
I havent renamed it in v2 of patches that I sent out. I'll send out a
cumulative patch that renames and exports tdb_hash() from an appropriate
location.
Regards,
--
Prerna Saxena
Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India
next prev parent reply other threads:[~2010-06-11 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 6:58 [Qemu-devel] [PATCH 0/3] Monitor commands for 'simple' trace backend Prerna Saxena
2010-06-08 7:01 ` [Qemu-devel] [PATCH 1/3] export tdb_hash() Prerna Saxena
2010-06-09 20:35 ` Luiz Capitulino
2010-06-11 10:32 ` Prerna Saxena [this message]
2010-06-08 7:04 ` [Qemu-devel] [PATCH 2/3] Monitor command 'trace' Prerna Saxena
2010-06-09 20:37 ` Luiz Capitulino
2010-06-11 10:46 ` Prerna Saxena
2010-06-08 7:08 ` [Qemu-devel] [PATCH 3/3] Toggle tracepoint state Prerna Saxena
2010-06-09 20:43 ` Luiz Capitulino
2010-06-11 10:57 ` Prerna Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1210B7.7090703@linux.vnet.ibm.com \
--to=prerna@linux.vnet.ibm.com \
--cc=Jan@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=maneesh@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).