From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34639 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ON1XP-0004w9-Nq
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 06:32:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1ON1XO-0007LK-2g
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 06:32:35 -0400
Received: from e23smtp06.au.ibm.com ([202.81.31.148]:42698)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1ON1XN-0007Kj-Gx
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 06:32:34 -0400
Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [202.81.31.247])
	by e23smtp06.au.ibm.com (8.14.4/8.13.1) with ESMTP id o5BAWNon014641
	for <qemu-devel@nongnu.org>; Fri, 11 Jun 2010 20:32:23 +1000
Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])
	by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o5BAWRst1589496
	for <qemu-devel@nongnu.org>; Fri, 11 Jun 2010 20:32:27 +1000
Received: from d23av04.au.ibm.com (loopback [127.0.0.1])
	by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	o5BAWRwX010885
	for <qemu-devel@nongnu.org>; Fri, 11 Jun 2010 20:32:27 +1000
Message-ID: <4C1210B7.7090703@linux.vnet.ibm.com>
Date: Fri, 11 Jun 2010 16:02:23 +0530
From: Prerna Saxena <prerna@linux.vnet.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] export tdb_hash()
References: <20100608122803.6a684a5e@zephyr>	<20100608123138.353f46f3@zephyr>
	<20100609173506.454225c7@redhat.com>
In-Reply-To: <20100609173506.454225c7@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, kvm@vger.kernel.org, Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, maneesh@linux.vnet.ibm.com, ananth@linux.vnet.ibm.com, Jan@us.ibm.com

On 06/10/2010 02:05 AM, Luiz Capitulino wrote:
> On Tue, 8 Jun 2010 12:31:38 +0530
> Prerna Saxena<prerna@linux.vnet.ibm.com>  wrote:
>
>> This exports tdb_hash() for use by tracing framework.
>
>   Suggest to rename it (eg. qemu_hash()) and move it to a better location, qdict
> is not the best module to export such service.
>

Would 'qemu-common.h' be a good place to export it ? If not, any 
suggestions on where else I can export it ?
I havent renamed it in v2 of patches that I sent out. I'll send out a 
cumulative patch that renames and exports tdb_hash() from an appropriate 
location.

Regards,
-- 
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India