From: Prerna Saxena <prerna@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, maneesh@linux.vnet.ibm.com,
ananth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 3/3] Toggle tracepoint state
Date: Fri, 11 Jun 2010 16:27:42 +0530 [thread overview]
Message-ID: <4C1216A6.1070109@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100609174335.5bee87fe@redhat.com>
Hi Luiz,
Thanks for taking time to review it.
On 06/10/2010 02:13 AM, Luiz Capitulino wrote:
> On Tue, 8 Jun 2010 12:38:58 +0530
> Prerna Saxena<prerna@linux.vnet.ibm.com> wrote:
>
>> This patch adds support for dynamically enabling/disabling of tracepoints.
>> Monitor commands added :
>> ....
>>
>
> Monitor has a bool type, please take a look in do_set_link().
>
Thanks for the pointer. Changed in v2.
>> + return;
>
> Not needed, also true for other functions in this patch, suggest reading
> CODING_STYLE for other style related issues in this series.
Done.
>
>>....
>>
Hope these commands would make it easy to visualize logged traces via
the monitor. I'd appreciate feedback on how v2 of the patches posted
can be enhanced.
--
Prerna Saxena
Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India
next prev parent reply other threads:[~2010-06-11 10:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 6:58 [Qemu-devel] [PATCH 0/3] Monitor commands for 'simple' trace backend Prerna Saxena
2010-06-08 7:01 ` [Qemu-devel] [PATCH 1/3] export tdb_hash() Prerna Saxena
2010-06-09 20:35 ` Luiz Capitulino
2010-06-11 10:32 ` Prerna Saxena
2010-06-08 7:04 ` [Qemu-devel] [PATCH 2/3] Monitor command 'trace' Prerna Saxena
2010-06-09 20:37 ` Luiz Capitulino
2010-06-11 10:46 ` Prerna Saxena
2010-06-08 7:08 ` [Qemu-devel] [PATCH 3/3] Toggle tracepoint state Prerna Saxena
2010-06-09 20:43 ` Luiz Capitulino
2010-06-11 10:57 ` Prerna Saxena [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-16 12:35 [Qemu-devel] [PATCH 0/3] Monitor support QEMU trace framework Prerna Saxena
2010-06-16 12:44 ` [Qemu-devel] [PATCH 3/3] Toggle tracepoint state Prerna Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1216A6.1070109@linux.vnet.ibm.com \
--to=prerna@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=maneesh@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).