From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40426 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ON1vt-0000a7-Ha
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 06:57:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1ON1vs-0002Xl-BP
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 06:57:53 -0400
Received: from e23smtp02.au.ibm.com ([202.81.31.144]:48900)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <prerna@linux.vnet.ibm.com>) id 1ON1vr-0002Tr-PV
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 06:57:52 -0400
Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245])
	by e23smtp02.au.ibm.com (8.14.4/8.13.1) with ESMTP id o5BAs1C3008043
	for <qemu-devel@nongnu.org>; Fri, 11 Jun 2010 20:54:01 +1000
Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o5BAvj6q1745086
	for <qemu-devel@nongnu.org>; Fri, 11 Jun 2010 20:57:45 +1000
Received: from d23av02.au.ibm.com (loopback [127.0.0.1])
	by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	o5BAvjn4007281
	for <qemu-devel@nongnu.org>; Fri, 11 Jun 2010 20:57:45 +1000
Message-ID: <4C1216A6.1070109@linux.vnet.ibm.com>
Date: Fri, 11 Jun 2010 16:27:42 +0530
From: Prerna Saxena <prerna@linux.vnet.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3] Toggle tracepoint state
References: <20100608122803.6a684a5e@zephyr>	<20100608123858.6d7dc770@zephyr>
	<20100609174335.5bee87fe@redhat.com>
In-Reply-To: <20100609174335.5bee87fe@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, maneesh@linux.vnet.ibm.com, ananth@linux.vnet.ibm.com

Hi Luiz,
Thanks for taking time to review it.

On 06/10/2010 02:13 AM, Luiz Capitulino wrote:
> On Tue, 8 Jun 2010 12:38:58 +0530
> Prerna Saxena<prerna@linux.vnet.ibm.com>  wrote:
>
>> This patch adds support for dynamically enabling/disabling of tracepoints.
>> Monitor commands added :
>> ....
>>
>
>   Monitor has a bool type, please take a look in do_set_link().
>

Thanks for the pointer. Changed in v2.

>> +    return;
>
>   Not needed, also true for other functions in this patch, suggest reading
> CODING_STYLE for other style related issues in this series.

Done.

>
>>....
>>

Hope these commands would make it easy to visualize logged traces via 
the monitor. I'd appreciate feedback on how v2 of the patches posted 
can be enhanced.

-- 
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India