From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47685 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ON32u-0004Ts-83
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 08:09:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1ON32s-0004WY-75
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 08:09:11 -0400
Received: from david.siemens.de ([192.35.17.14]:24442)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1ON32r-0004Uz-P3
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 08:09:10 -0400
Message-ID: <4C122758.4020808@siemens.com>
Date: Fri, 11 Jun 2010 14:08:56 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC v2] [PATCH 0/3] Monitor Support for 'simple'
	trace backend
References: <20100611003811.2635fa5d@zephyr>
	<m37hm5lrrr.fsf@blackfin.pond.sub.org>
In-Reply-To: <m37hm5lrrr.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>, "maneesh@linux.vnet.ibm.com" <maneesh@linux.vnet.ibm.com>, "ananth@linux.vnet.ibm.com" <ananth@linux.vnet.ibm.com>, Prerna Saxena <prerna@linux.vnet.ibm.com>

Markus Armbruster wrote:
> Prerna Saxena <prerna@linux.vnet.ibm.com> writes:
> 
>> This is v2 of monitor commands based on Stefan's trace framework :
>> ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
>>
>> This adds the following monitor commands for the 'simple' backend:
>> - info trace 		: to view current contents of the trace buffer.
>> - info tracepoints 	: to view all available tracepoints and their 
>> 			  state.
>> - tracepoint NAME on|off: to enable/disable the logging of data from 
>> 			  tracepoint 'NAME'.
>>
>>
>> Changelog :
>> - Command 'info trace' is used to view current contents of buffer, in 
>> place of 'trace'.
>> - Cleanups
> 
> Do we want this in QMP?

For sure IMO. Maybe not in a hurry to avoid breakages until the whole
tracing infrastructure has settled, but long-term to ease scripting etc.

Still, let's not add this as an old-style monitor command, rather
convert it to the new style, maybe blocking QMP for now. I'll post the
required infrastructure for that blocking along my next device_show
series (hopefully the next days).

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux