* [Qemu-devel] [PATCH] Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE
@ 2010-06-11 14:02 Jes.Sorensen
2010-06-11 14:55 ` Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Jes.Sorensen @ 2010-06-11 14:02 UTC (permalink / raw)
To: anthony; +Cc: bandwconstruction, qemu-devel, Jes Sorensen
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE in hw/fdc.c
Per https://bugs.launchpad.net/qemu/+bug/424453 the correct values
for FD_CMD_SAVE is 0x2e and FD_CMD_RESTORE is 0x4e. Verified against
the Intel 82078 manual which can be found at:
http://wiki.qemu.org/Documentation/HardwareManuals page 22.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
hw/fdc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/fdc.c b/hw/fdc.c
index 6306496..d911d64 100644
--- a/hw/fdc.c
+++ b/hw/fdc.c
@@ -370,9 +370,9 @@ enum {
FD_CMD_PART_ID = 0x18,
FD_CMD_SCAN_LOW_OR_EQUAL = 0x19,
FD_CMD_SCAN_HIGH_OR_EQUAL = 0x1d,
- FD_CMD_SAVE = 0x2c,
+ FD_CMD_SAVE = 0x2e,
FD_CMD_OPTION = 0x33,
- FD_CMD_RESTORE = 0x4c,
+ FD_CMD_RESTORE = 0x4e,
FD_CMD_DRIVE_SPECIFICATION_COMMAND = 0x8e,
FD_CMD_RELATIVE_SEEK_OUT = 0x8f,
FD_CMD_FORMAT_AND_WRITE = 0xcd,
--
1.6.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE
2010-06-11 14:02 [Qemu-devel] [PATCH] Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE Jes.Sorensen
@ 2010-06-11 14:55 ` Kevin Wolf
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Wolf @ 2010-06-11 14:55 UTC (permalink / raw)
To: Jes.Sorensen; +Cc: bandwconstruction, qemu-devel
Am 11.06.2010 16:02, schrieb Jes.Sorensen@redhat.com:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE in hw/fdc.c
>
> Per https://bugs.launchpad.net/qemu/+bug/424453 the correct values
> for FD_CMD_SAVE is 0x2e and FD_CMD_RESTORE is 0x4e. Verified against
> the Intel 82078 manual which can be found at:
> http://wiki.qemu.org/Documentation/HardwareManuals page 22.
>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-11 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-11 14:02 [Qemu-devel] [PATCH] Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE Jes.Sorensen
2010-06-11 14:55 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).