From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34704 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ONTpC-0007M3-Es
	for qemu-devel@nongnu.org; Sat, 12 Jun 2010 12:44:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1ONTp9-00073h-U0
	for qemu-devel@nongnu.org; Sat, 12 Jun 2010 12:44:50 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:52764)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1ONTp9-00073L-H4
	for qemu-devel@nongnu.org; Sat, 12 Jun 2010 12:44:47 -0400
Message-ID: <4C13B978.1000805@web.de>
Date: Sat, 12 Jun 2010 18:44:40 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak
	in create_config
References: <4C12A375.6050201@web.de> <20100612115557.GK3008@ohm.aurel32.net>
	<4C137CA6.1020808@web.de> <20100612143758.GD1940@ohm.aurel32.net>
In-Reply-To: <20100612143758.GD1940@ohm.aurel32.net>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig79B34989CD21532B6E1A0A27"
Sender: jan.kiszka@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig79B34989CD21532B6E1A0A27
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Aurelien Jarno wrote:
> On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote:
>> Aurelien Jarno wrote:
>>> On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> Only match on true dir variable assignments, avoid generating garbag=
e
>>>> due to the "# Configured with: ..." line which may contain "*dir=3D"=
 as
>>>> well.
>>> Wouldn't it be better to skip all lines starting with '#', as this
>>> problem might happen again after some more changes?
>>>
>>> Or maybe we should do both.
>> This is what the patch (implicitly) does.
>=20
> Yes, but only for this line. What I mean is something more generic
> like:
>=20
> "#"*) # comment
>     continue
>     ;;
>=20

IMO, that would only paper over suboptimally expressed patterns for the
other line evaluations.

Jan


--------------enig79B34989CD21532B6E1A0A27
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkwTuXwACgkQitSsb3rl5xT0EwCgzMK78EHiNhO1SxgBMH0mnNnk
hEUAn0QgcZiH6YxGQUNj/2HwXC3bL2e0
=ic9j
-----END PGP SIGNATURE-----

--------------enig79B34989CD21532B6E1A0A27--