From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43937 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OO3hH-0006Mc-SQ
	for qemu-devel@nongnu.org; Mon, 14 Jun 2010 03:03:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OO3hG-0000Yw-Il
	for qemu-devel@nongnu.org; Mon, 14 Jun 2010 03:03:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1026)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OO3hG-0000Yg-AC
	for qemu-devel@nongnu.org; Mon, 14 Jun 2010 03:03:02 -0400
Message-ID: <4C15D413.6020803@redhat.com>
Date: Mon, 14 Jun 2010 09:02:43 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <20100614054923.879.33717.stgit@localhost.localdomain>
In-Reply-To: <20100614054923.879.33717.stgit@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device
	hierarchy string
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: chrisw@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, paul@codesourcery.com, avi@redhat.com

   Hi,

> My premise with this attempt is that we walk the hierarchy and use the
> names to create the base of the path.  As we get to the device,
> particularly to the parent bus of the device, we need to start looking at
> properties to ensure uniqueness.

You'll need that for every bus along the way down to the device.  Create 
a virtual machine with two lsi scsi host adapters, then attach a disk 
with scsi id 0 to each.  Just the scsi id isn't good enougth to identify 
the device.  You'll need the lsi pci address too.

> For now, the only properties I've tagged as path
> properties are PCI bus addresses and MAC addresses.

mac address isn't needed here.  You need the property which specifies 
the bus address.  For PCI this obviously is the PCI address.  For scsi 
the scsi id.  For ISA you can use the I/O port base.  virtio-serial the 
port number, ...

cheers,
   Gerd