From: Gerd Hoffmann <kraxel@redhat.com>
To: Shahar Havivi <shaharh@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] Return usb device to host on exit
Date: Mon, 14 Jun 2010 11:50:07 +0200 [thread overview]
Message-ID: <4C15FB4F.5030104@redhat.com> (raw)
In-Reply-To: <c1f8a92e3cfc5da8456852a308cc3911b29af67f.1276335589.git.shaharh@redhat.com>
> @@ -1066,6 +1077,7 @@ USBDevice *usb_host_device_open(const char *devname)
> qdev_prop_set_uint32(&dev->qdev, "vendorid", filter.vendor_id);
> qdev_prop_set_uint32(&dev->qdev, "productid", filter.product_id);
> qdev_init_nofail(&dev->qdev);
> + atexit(usb_host_cleanup);
> return dev;
You'll register atexit multiple times here (once per device).
I still think this should use exit notifiers, see
http://patchwork.ozlabs.org/patch/54571/ (doesn't apply cleanly and
more, will post a rebased version later today).
cheers,
Gerd
next prev parent reply other threads:[~2010-06-14 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-12 9:58 [Qemu-devel] [PATCH 0/2 v3] Release usb devices on shutdown and usb_del command Shahar Havivi
2010-06-12 9:59 ` [Qemu-devel] [PATCH 1/2] Return usb device to host on " Shahar Havivi
2010-06-12 9:59 ` [Qemu-devel] [PATCH 2/2] Return usb device to host on exit Shahar Havivi
2010-06-14 9:50 ` Gerd Hoffmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-15 18:05 [Qemu-devel] [PATCH 0/2 v4] Release usb devices on shutdown and usb_del Shahar Havivi
2010-06-15 18:06 ` [Qemu-devel] [PATCH 2/2] Return usb device to host on exit Shahar Havivi
2010-06-16 8:48 ` Gerd Hoffmann
2010-06-16 10:18 ` Shahar Havivi
2010-06-16 12:15 [Qemu-devel] [PATCH 0/2 v5] Release usb devices on shutdown and usb_del Shahar Havivi
2010-06-16 12:16 ` [Qemu-devel] [PATCH 2/2] Return usb device to host on exit Shahar Havivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C15FB4F.5030104@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shaharh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).