From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56523 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOAla-0007KH-RC for qemu-devel@nongnu.org; Mon, 14 Jun 2010 10:35:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOAlZ-0007Aa-NE for qemu-devel@nongnu.org; Mon, 14 Jun 2010 10:35:58 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:41347) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOAlZ-0007AD-Jn for qemu-devel@nongnu.org; Mon, 14 Jun 2010 10:35:57 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e4.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o5EEMcoa013379 for ; Mon, 14 Jun 2010 10:22:38 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5EEZrkB102152 for ; Mon, 14 Jun 2010 10:35:53 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o5EEZqj1031019 for ; Mon, 14 Jun 2010 11:35:52 -0300 Message-ID: <4C163E48.7010108@linux.vnet.ibm.com> Date: Mon, 14 Jun 2010 09:35:52 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <20100609175215.2e2071a0@redhat.com> <20100611113022.27490bfe@redhat.com> <4C124A72.9000807@codemonkey.ws> <4C16357B.70308@linux.vnet.ibm.com> <20100614112414.1bead4ba@redhat.com> In-Reply-To: <20100614112414.1bead4ba@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, Juan Quintela On 06/14/2010 09:24 AM, Luiz Capitulino wrote: > On Mon, 14 Jun 2010 08:58:19 -0500 > Anthony Liguori wrote: > > >> For 0.13, we need to focus on introducing the least disruptive change >> that addresses the fundamental requirement--allow clients to avoid a >> polling loop for determining when migration ends. Having a single event >> with no payload is an extremely simple change. >> > Agreed. > > Actually, I'm slightly against introducing the done event too. While the > polling is undesired, I don't think that having an event only for a release > is worth it. > I don't think we can realistically remove it. In my mind, what deprecate means with respect to QMP is that we never add additional features to the deprecated commands. Right now, 'migrate', 'info migrate', and MIGRATE_DONE do not provide very rich error reporting. They really just provide a boolean failed/succeeded. For 0.14, we'll have to introduce a 'migrate2' command and deprecate the old 'migrate' command. 'migrate2' will provide rich error reporting and all new features will be added to 'migrate2'. BTW, I lack any kind of naming creativity so 'migrate2' is not necessarily what it ought to be called. Regards, Anthony Liguori