From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56917 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOB0h-0006mW-4M for qemu-devel@nongnu.org; Mon, 14 Jun 2010 10:51:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOB0f-0001Mm-IZ for qemu-devel@nongnu.org; Mon, 14 Jun 2010 10:51:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2037) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOB0f-0001Mc-7j for qemu-devel@nongnu.org; Mon, 14 Jun 2010 10:51:33 -0400 Message-ID: <4C1641EF.9070001@redhat.com> Date: Mon, 14 Jun 2010 17:51:27 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20100614083053.GC21797@redhat.com> <20100614135425.GA18002@morn.localdomain> <20100614140959.GI21797@redhat.com> In-Reply-To: <20100614140959.GI21797@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Kevin O'Connor , seabios@seabios.org, qemu-devel@nongnu.org On 06/14/2010 05:09 PM, Gleb Natapov wrote: >> Could we just have qemu build the hpet tables and pass them through to >> seabios? Perhaps using the qemu_cfg_acpi_additional_tables() method. >> >> > Possible, and I considered that. I personally prefer to pass minimum > information required for seabios to discover underlying HW and leave > ACPI table creation to seabios. That is how things done for HW that > seabios can actually detect. If we will go your way pretty soon we will > move creation of ACPI/SMBIOS/MP tables into qemu and IMHO this will be > step backworkds. > I agree. ACPI is a firmware/OS interface. If we move ACPI table generation into qemu, it becomes a mixed hardware/firmware/OS interface. Better keep those interfaces separate: hardware/firmware (fwcfg) and firmware/OS (acpi). -- error compiling committee.c: too many arguments to function