From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51229 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOCVP-0004p4-5B
	for qemu-devel@nongnu.org; Mon, 14 Jun 2010 12:27:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OOCVN-0002uK-7x
	for qemu-devel@nongnu.org; Mon, 14 Jun 2010 12:27:22 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:45877)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OOCVN-0002uE-5l
	for qemu-devel@nongnu.org; Mon, 14 Jun 2010 12:27:21 -0400
Received: by qyk5 with SMTP id 5so464835qyk.4
	for <qemu-devel@nongnu.org>; Mon, 14 Jun 2010 09:27:20 -0700 (PDT)
Message-ID: <4C165866.2050707@codemonkey.ws>
Date: Mon, 14 Jun 2010 11:27:18 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] qemu-option: Fix uninitialized value in
	append_option_parameter
References: <1276244381-7569-1-git-send-email-kwolf@redhat.com>
In-Reply-To: <1276244381-7569-1-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: xudong.hao@intel.com, qemu-devel@nongnu.org, morita.kazutaka@lab.ntt.co.jp

On 06/11/2010 03:19 AM, Kevin Wolf wrote:
> When dest is NULL, i.e. a new copy of the list is created, we don't get a
> properly terminated list after the realloc. Initialize it as an empty list.
>
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>
> Xudong, can you please try this one? I think it should fix your qemu-img
> problem.
>
>   qemu-option.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-option.c b/qemu-option.c
> index acd74f9..f884865 100644
> --- a/qemu-option.c
> +++ b/qemu-option.c
> @@ -378,6 +378,7 @@ QEMUOptionParameter *append_option_parameters(QEMUOptionParameter *dest,
>       num_options += count_option_parameters(list);
>
>       dest = qemu_realloc(dest, (num_options + 1) * sizeof(QEMUOptionParameter));
> +    dest[num_dest_options].name = NULL;
>
>       while (list&&  list->name) {
>           if (get_option_parameter(dest, list->name) == NULL) {
>