From: Anthony Liguori <anthony@codemonkey.ws>
To: Jes.Sorensen@redhat.com
Cc: dprotti@flowgate.net, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] Remove unused DEBUG defines from hw/msix.c
Date: Mon, 14 Jun 2010 11:29:05 -0500 [thread overview]
Message-ID: <4C1658D1.7070906@codemonkey.ws> (raw)
In-Reply-To: <1276527917-24703-2-git-send-email-Jes.Sorensen@redhat.com>
On 06/14/2010 10:05 AM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Remove unused DEBUG defines from hw/msix.c to avoid having anything
> define the word DEBUG without any additions such as MSIX_DEBUG.
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> hw/msix.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/hw/msix.c b/hw/msix.c
> index 1613bb4..d99403a 100644
> --- a/hw/msix.c
> +++ b/hw/msix.c
> @@ -42,15 +42,6 @@
> #define MSIX_MAX_ENTRIES 32
>
>
> -#ifdef MSIX_DEBUG
> -#define DEBUG(fmt, ...) \
> - do { \
> - fprintf(stderr, "%s: " fmt, __func__ , __VA_ARGS__); \
> - } while (0)
> -#else
> -#define DEBUG(fmt, ...) do { } while(0)
> -#endif
> -
> /* Flag for interrupt controller to declare MSI-X support */
> int msix_supported;
>
>
prev parent reply other threads:[~2010-06-14 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 15:05 [Qemu-devel] [PATCH 0/2] Remove naked #define DEBUG to allow -DDEBUG builds Jes.Sorensen
2010-06-14 15:05 ` [Qemu-devel] [PATCH 1/2] Remove unused DEBUG defines from hw/msix.c Jes.Sorensen
2010-06-14 15:05 ` [Qemu-devel] [PATCH 2/2] Change #define DEBUG to #define E1000_DEBUG in hw/e1000.c Jes.Sorensen
2010-06-14 16:29 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1658D1.7070906@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=Jes.Sorensen@redhat.com \
--cc=dprotti@flowgate.net \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).