From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59026 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOGkA-0000ck-UT for qemu-devel@nongnu.org; Mon, 14 Jun 2010 16:59:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOGjN-0007xh-T6 for qemu-devel@nongnu.org; Mon, 14 Jun 2010 16:58:07 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:56474) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOGjN-0007ly-QE for qemu-devel@nongnu.org; Mon, 14 Jun 2010 16:58:05 -0400 Received: by mail-iw0-f173.google.com with SMTP id 10so4582648iwn.4 for ; Mon, 14 Jun 2010 13:58:05 -0700 (PDT) Message-ID: <4C1697DF.3040100@codemonkey.ws> Date: Mon, 14 Jun 2010 15:58:07 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] migration: use qemu_free() instead of free(). References: <1276062271-27678-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> In-Reply-To: <1276062271-27678-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yoshiaki Tamura Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 06/09/2010 12:44 AM, Yoshiaki Tamura wrote: > Although there is no difference, other migration related code use > qemu_free(), and it should be better to be consistent. > > Signed-off-by: Yoshiaki Tamura > Applied. Thanks. Regards, Anthony Liguori > --- > migration.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/migration.c b/migration.c > index fbf2339..64ed36e 100644 > --- a/migration.c > +++ b/migration.c > @@ -396,7 +396,7 @@ void migrate_fd_release(MigrationState *mig_state) > s->state = MIG_STATE_CANCELLED; > migrate_fd_cleanup(s); > } > - free(s); > + qemu_free(s); > } > > void migrate_fd_wait_for_unfreeze(void *opaque) >