From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49617 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOGq0-00052P-B1 for qemu-devel@nongnu.org; Mon, 14 Jun 2010 17:04:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOGpy-0000hv-N6 for qemu-devel@nongnu.org; Mon, 14 Jun 2010 17:04:55 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:43469) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOGpy-0000hj-Ky for qemu-devel@nongnu.org; Mon, 14 Jun 2010 17:04:54 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by e9.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o5EKo5HI030584 for ; Mon, 14 Jun 2010 16:50:05 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5EL4mkA1466604 for ; Mon, 14 Jun 2010 17:04:48 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o5EL4mo8017689 for ; Mon, 14 Jun 2010 18:04:48 -0300 Message-ID: <4C169973.60004@linux.vnet.ibm.com> Date: Mon, 14 Jun 2010 16:04:51 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH-V7 09/10] virtio-9p: Implement Security model for mknod References: <1276547689-3408-1-git-send-email-jvrao@linux.vnet.ibm.com> <1276547689-3408-10-git-send-email-jvrao@linux.vnet.ibm.com> In-Reply-To: <1276547689-3408-10-git-send-email-jvrao@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Venkateswararao Jujjuri (JV)" Cc: qemu-devel@nongnu.org On 06/14/2010 03:34 PM, Venkateswararao Jujjuri (JV) wrote: > Mapped mode stores extended attributes in the user space of the extended > attributes. Given that the user space extended attributes are available > to regular files only, special files are created as regular files on the > fileserver and appropriate mode bits are added to the extended attributes. > This method presents all special files and symlinks as regular files on the > fileserver while they are represented as special files on the guest mount. > > On Host/Fileserver: > -rw-------. 1 virfsuid virtfsgid 0 2010-05-11 09:36 afifo > -rw-------. 1 virfsuid virtfsgid 0 2010-05-11 09:32 blkdev > -rw-------. 1 virfsuid virtfsgid 0 2010-05-11 09:33 chardev > > On Guest/Client: > prw-r--r-- 1 guestuser guestuser 0 2010-05-11 12:36 afifo > brw-r--r-- 1 guestuser guestuser 0, 0 2010-05-11 12:32 blkdev > crw-r--r-- 1 guestuser guestuser 4, 5 2010-05-11 12:33 chardev > > In the passthrough securit model, specifal files are directly created > on the fileserver. But the user credential > > Signed-off-by: Venkateswararao Jujjuri > --- > hw/file-op-9p.h | 2 +- > hw/virtio-9p-local.c | 34 ++++++++++++++++++++++++++++++++-- > hw/virtio-9p.c | 14 ++++++++++---- > 3 files changed, 43 insertions(+), 7 deletions(-) > > > static int local_mksock(FsContext *ctx2, const char *path) > diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c > index 1a25e96..d276db3 100644 > --- a/hw/virtio-9p.c > +++ b/hw/virtio-9p.c > @@ -160,9 +160,15 @@ static int v9fs_do_chmod(V9fsState *s, V9fsString *path, mode_t mode) > return s->ops->chmod(&s->ctx, path->data,&cred); > } > > -static int v9fs_do_mknod(V9fsState *s, V9fsString *path, mode_t mode, dev_t dev) > +static int v9fs_do_mknod(V9fsState *s, V9fsCreateState *vs, mode_t mode, > + dev_t dev) > { > You've added this function *before* you actually declare V9fsCreateState which is happening way down before v9fs_post_create(). Did you actually build these patches before sending them to the list? Regards, Anthony Liguori