From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39679 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOO4C-0007t2-Dt for qemu-devel@nongnu.org; Tue, 15 Jun 2010 00:48:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOO4A-0004nd-RV for qemu-devel@nongnu.org; Tue, 15 Jun 2010 00:48:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41609) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOO4A-0004nS-KL for qemu-devel@nongnu.org; Tue, 15 Jun 2010 00:48:02 -0400 Message-ID: <4C1705FB.2040605@redhat.com> Date: Tue, 15 Jun 2010 07:47:55 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20100614083053.GC21797@redhat.com> <20100614135425.GA18002@morn.localdomain> <20100614140959.GI21797@redhat.com> <4C1641EF.9070001@redhat.com> <20100614182521.GA22454@morn.localdomain> <4C16852F.9070904@codemonkey.ws> In-Reply-To: <4C16852F.9070904@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin O'Connor , seabios@seabios.org, qemu-devel@nongnu.org On 06/14/2010 10:38 PM, Anthony Liguori wrote: > > I think we can be pretty flexible as long as we're careful about > releases. For instance, I've applied Gleb's current patch but won't > update SeaBIOS until the interface is worked out. If we decide to > implement a new interface, there's no harm since we've never had a > qemu build that had a combination of SeaBIOS and fw_cfg that didn't work. Or we can choose a new interface number if the interface changes. One of Kevin's points was that the ACPI tables are a documented interface. AFAIR, the firmware configuration interface isn't. We need to start documenting it (and reject patches without accompanying documentation). -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.