From: Kevin Wolf <kwolf@redhat.com>
To: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: aliguori@us.ibm.com, sheepdog@lists.wpkg.org,
chris.krumme@windriver.com, kvm@vger.kernel.org,
qemu-devel@nongnu.org, Christian Brunner <chb@muc.de>
Subject: [Qemu-devel] Re: [PATCH v5] block: add sheepdog driver for distributed storage support
Date: Tue, 15 Jun 2010 10:24:14 +0200 [thread overview]
Message-ID: <4C1738AE.8040906@redhat.com> (raw)
In-Reply-To: <878w6hs8e5.wl%morita.kazutaka@lab.ntt.co.jp>
Am 14.06.2010 21:48, schrieb MORITA Kazutaka:
>> 3) qemu-io aio_read/write doesn't seem to work well with it. I only get
>> the result of the AIO request when I exit qemu-io. This may be a qemu-io
>> problem or a Sheepdog one. We need to look into this, qemu-io is
>> important for testing and debugging (particularly for qemu-iotests)
>>
> Sheepdog receives responses from the server in the fd handler to the
> socket connection. But, while qemu-io executes aio_read/aio_write, it
> doesn't call qemu_aio_wait() and the fd handler isn't invoked at all.
> This seems to be the reason of the problem.
>
> I'm not sure this is a qemu-io problem or a Sheepdog one. If it is a
> qemu-io problem, we need to call qemu_aio_wait() somewhere in the
> command_loop(), I guess. If it is a Sheepdog problem, we need to
> consider another mechanism to receive responses...
Not sure either.
I think posix-aio-compat needs fd handlers to be called, too, and it
kind of works. I'm saying "kind of" because after an aio_read/write
command qemu-io exits (it doesn't with Sheepdog). And when exiting there
is a qemu_aio_wait(), so this explains why you get a result there.
I guess it's a bug in the posix-aio-compat case rather than with Sheepdog.
The good news is that if qemu-iotests works with only one aio_read/write
command before qemu-io exits, it's going to work with Sheepdog, too.
Kevin
next prev parent reply other threads:[~2010-06-15 8:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 18:00 [Qemu-devel] [PATCH v5] block: add sheepdog driver for distributed storage support MORITA Kazutaka
2010-06-11 13:35 ` [Qemu-devel] " Kevin Wolf
2010-06-14 19:48 ` MORITA Kazutaka
2010-06-15 8:24 ` Kevin Wolf [this message]
2010-06-15 12:33 ` MORITA Kazutaka
2010-06-17 19:15 ` Christian Brunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1738AE.8040906@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=chb@muc.de \
--cc=chris.krumme@windriver.com \
--cc=kvm@vger.kernel.org \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=sheepdog@lists.wpkg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).