From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36420 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OORe2-0007T9-M9
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 04:37:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OORe1-0004sz-FA
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 04:37:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5029)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OORe1-0004sm-8W
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 04:37:17 -0400
Message-ID: <4C173BB4.4020208@redhat.com>
Date: Tue, 15 Jun 2010 10:37:08 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] add pflib: PixelFormat conversion library.
References: <1276530378-24326-1-git-send-email-kraxel@redhat.com>
	<4C165909.9060605@codemonkey.ws>
In-Reply-To: <4C165909.9060605@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

>> +++ b/pflib.h
>> @@ -0,0 +1,6 @@
>
> Missing #if guards and missing license/copyright.

Will add.

> Are you planning on using this somewhere?

Yes, for both fbdev and spice.

> I'd prefer to merge this with
> some code to use it somewhere as right now, it's dead code.

Ok, I'll resend it with fbdev then.

cheers,
   Gerd