From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Marcos Oviedo <moviedo.maillist@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command
Date: Tue, 15 Jun 2010 10:46:15 +0200 [thread overview]
Message-ID: <4C173DD7.9050805@redhat.com> (raw)
In-Reply-To: <4C16600A.4030208@codemonkey.ws>
Hi,
>> If the guest is stopped while unplugging the device the unplug should
>> happen as soon as the guest is unpaused.
>
> This is a case where the fundamental problem is that the pci_del command
> should block until the guest has actually responded to the request.
You can't block. Unplug might never ever happen for various reasons.
IMHO the only sane way to handle it is sending a event when the unplug
is done.
> pci_del returning with no error and yet not having the operation
> complete is certainly a usability issue.
There simply is no clear error condition. If the guest didn't respond
(yet) you don't know whenever it just needs a bit more time to shutdown
the device or if unplugging the device failed.
cheers,
Gerd
next prev parent reply other threads:[~2010-06-15 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 5:37 [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command Marcos Oviedo
2010-06-09 6:39 ` Markus Armbruster
2010-06-09 7:38 ` Gerd Hoffmann
2010-06-09 14:00 ` Marcos Oviedo
2010-06-09 14:27 ` Gerd Hoffmann
2010-06-14 16:59 ` Anthony Liguori
2010-06-15 8:46 ` Gerd Hoffmann [this message]
2010-06-15 9:03 ` Markus Armbruster
2010-06-17 18:15 ` Luiz Capitulino
2010-06-17 18:20 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C173DD7.9050805@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=moviedo.maillist@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).