* [Qemu-devel] [PATCH] pci hotplug: staticfy pci_device_hot_remove().
@ 2010-06-15 3:48 Isaku Yamahata
2010-06-15 8:58 ` [Qemu-devel] " Gerd Hoffmann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Isaku Yamahata @ 2010-06-15 3:48 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Michael S. Tsirkin
staticfy pci_device_hot_remove().
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
hw/pci-hotplug.c | 2 +-
sysemu.h | 1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
index c39e640..098264c 100644
--- a/hw/pci-hotplug.c
+++ b/hw/pci-hotplug.c
@@ -258,7 +258,7 @@ void pci_device_hot_add(Monitor *mon, const QDict *qdict)
}
#endif
-int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
+static int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
{
PCIDevice *d;
int dom, bus;
diff --git a/sysemu.h b/sysemu.h
index c758243..9c988bb 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -149,7 +149,6 @@ extern unsigned int nb_prom_envs;
/* pci-hotplug */
void pci_device_hot_add(Monitor *mon, const QDict *qdict);
void drive_hot_add(Monitor *mon, const QDict *qdict);
-int pci_device_hot_remove(Monitor *mon, const char *pci_addr);
void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict);
/* serial ports */
--
1.6.6.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] Re: [PATCH] pci hotplug: staticfy pci_device_hot_remove().
2010-06-15 3:48 [Qemu-devel] [PATCH] pci hotplug: staticfy pci_device_hot_remove() Isaku Yamahata
@ 2010-06-15 8:58 ` Gerd Hoffmann
2010-06-21 9:54 ` [Qemu-devel] " Isaku Yamahata
2010-06-21 11:37 ` [Qemu-devel] " Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2010-06-15 8:58 UTC (permalink / raw)
To: Isaku Yamahata; +Cc: qemu-devel, Michael S. Tsirkin
On 06/15/10 05:48, Isaku Yamahata wrote:
> staticfy pci_device_hot_remove().
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] pci hotplug: staticfy pci_device_hot_remove().
2010-06-15 3:48 [Qemu-devel] [PATCH] pci hotplug: staticfy pci_device_hot_remove() Isaku Yamahata
2010-06-15 8:58 ` [Qemu-devel] " Gerd Hoffmann
@ 2010-06-21 9:54 ` Isaku Yamahata
2010-06-21 11:37 ` [Qemu-devel] " Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Isaku Yamahata @ 2010-06-21 9:54 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Michael S. Tsirkin
Ping.
Michael, do you have any comment on this?
On Tue, Jun 15, 2010 at 12:48:36PM +0900, Isaku Yamahata wrote:
> staticfy pci_device_hot_remove().
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
> hw/pci-hotplug.c | 2 +-
> sysemu.h | 1 -
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
> index c39e640..098264c 100644
> --- a/hw/pci-hotplug.c
> +++ b/hw/pci-hotplug.c
> @@ -258,7 +258,7 @@ void pci_device_hot_add(Monitor *mon, const QDict *qdict)
> }
> #endif
>
> -int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
> +static int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
> {
> PCIDevice *d;
> int dom, bus;
> diff --git a/sysemu.h b/sysemu.h
> index c758243..9c988bb 100644
> --- a/sysemu.h
> +++ b/sysemu.h
> @@ -149,7 +149,6 @@ extern unsigned int nb_prom_envs;
> /* pci-hotplug */
> void pci_device_hot_add(Monitor *mon, const QDict *qdict);
> void drive_hot_add(Monitor *mon, const QDict *qdict);
> -int pci_device_hot_remove(Monitor *mon, const char *pci_addr);
> void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict);
>
> /* serial ports */
> --
> 1.6.6.1
>
>
--
yamahata
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] Re: [PATCH] pci hotplug: staticfy pci_device_hot_remove().
2010-06-15 3:48 [Qemu-devel] [PATCH] pci hotplug: staticfy pci_device_hot_remove() Isaku Yamahata
2010-06-15 8:58 ` [Qemu-devel] " Gerd Hoffmann
2010-06-21 9:54 ` [Qemu-devel] " Isaku Yamahata
@ 2010-06-21 11:37 ` Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2010-06-21 11:37 UTC (permalink / raw)
To: Isaku Yamahata; +Cc: qemu-devel, Gerd Hoffmann
On Tue, Jun 15, 2010 at 12:48:36PM +0900, Isaku Yamahata wrote:
> staticfy pci_device_hot_remove().
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Applied, thanks.
> ---
> hw/pci-hotplug.c | 2 +-
> sysemu.h | 1 -
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
> index c39e640..098264c 100644
> --- a/hw/pci-hotplug.c
> +++ b/hw/pci-hotplug.c
> @@ -258,7 +258,7 @@ void pci_device_hot_add(Monitor *mon, const QDict *qdict)
> }
> #endif
>
> -int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
> +static int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
> {
> PCIDevice *d;
> int dom, bus;
> diff --git a/sysemu.h b/sysemu.h
> index c758243..9c988bb 100644
> --- a/sysemu.h
> +++ b/sysemu.h
> @@ -149,7 +149,6 @@ extern unsigned int nb_prom_envs;
> /* pci-hotplug */
> void pci_device_hot_add(Monitor *mon, const QDict *qdict);
> void drive_hot_add(Monitor *mon, const QDict *qdict);
> -int pci_device_hot_remove(Monitor *mon, const char *pci_addr);
> void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict);
>
> /* serial ports */
> --
> 1.6.6.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-06-21 11:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-15 3:48 [Qemu-devel] [PATCH] pci hotplug: staticfy pci_device_hot_remove() Isaku Yamahata
2010-06-15 8:58 ` [Qemu-devel] " Gerd Hoffmann
2010-06-21 9:54 ` [Qemu-devel] " Isaku Yamahata
2010-06-21 11:37 ` [Qemu-devel] " Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).