* [Qemu-devel] [PATCH] xen: Fix build error due to missing include
@ 2010-06-14 21:11 Jan Kiszka
2010-06-15 8:57 ` Markus Armbruster
2010-06-15 9:00 ` [Qemu-devel] " Kevin Wolf
0 siblings, 2 replies; 5+ messages in thread
From: Jan Kiszka @ 2010-06-14 21:11 UTC (permalink / raw)
To: Kevin Wolf; +Cc: Markus Armbruster, qemu-devel
From: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/xen_backend.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/xen_backend.h b/hw/xen_backend.h
index f07f7d4..cc25f9d 100644
--- a/hw/xen_backend.h
+++ b/hw/xen_backend.h
@@ -5,6 +5,7 @@
#include "sysemu.h"
#include "net.h"
#include "block_int.h"
+#include "blockdev.h"
/* ------------------------------------------------------------- */
--
1.6.0.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] xen: Fix build error due to missing include
2010-06-14 21:11 [Qemu-devel] [PATCH] xen: Fix build error due to missing include Jan Kiszka
@ 2010-06-15 8:57 ` Markus Armbruster
2010-06-15 9:02 ` Jan Kiszka
2010-06-15 9:00 ` [Qemu-devel] " Kevin Wolf
1 sibling, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2010-06-15 8:57 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Kevin Wolf, qemu-devel
Jan Kiszka <jan.kiszka@web.de> writes:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/xen_backend.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/xen_backend.h b/hw/xen_backend.h
> index f07f7d4..cc25f9d 100644
> --- a/hw/xen_backend.h
> +++ b/hw/xen_backend.h
> @@ -5,6 +5,7 @@
> #include "sysemu.h"
> #include "net.h"
> #include "block_int.h"
> +#include "blockdev.h"
>
> /* ------------------------------------------------------------- */
My bad. Thanks for fixing this! By the way, Is "block_int.h" really
needed here?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] xen: Fix build error due to missing include
2010-06-15 8:57 ` Markus Armbruster
@ 2010-06-15 9:02 ` Jan Kiszka
2010-06-15 9:26 ` Markus Armbruster
0 siblings, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2010-06-15 9:02 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Kevin Wolf, qemu-devel
Markus Armbruster wrote:
> Jan Kiszka <jan.kiszka@web.de> writes:
>
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> hw/xen_backend.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/xen_backend.h b/hw/xen_backend.h
>> index f07f7d4..cc25f9d 100644
>> --- a/hw/xen_backend.h
>> +++ b/hw/xen_backend.h
>> @@ -5,6 +5,7 @@
>> #include "sysemu.h"
>> #include "net.h"
>> #include "block_int.h"
>> +#include "blockdev.h"
>>
>> /* ------------------------------------------------------------- */
>
> My bad. Thanks for fixing this! By the way, Is "block_int.h" really
> needed here?
Something else broke when I removed it, haven't looked at details though.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] xen: Fix build error due to missing include
2010-06-15 9:02 ` Jan Kiszka
@ 2010-06-15 9:26 ` Markus Armbruster
0 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2010-06-15 9:26 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Kevin Wolf, qemu-devel
Jan Kiszka <jan.kiszka@siemens.com> writes:
> Markus Armbruster wrote:
>> Jan Kiszka <jan.kiszka@web.de> writes:
>>
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>> hw/xen_backend.h | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hw/xen_backend.h b/hw/xen_backend.h
>>> index f07f7d4..cc25f9d 100644
>>> --- a/hw/xen_backend.h
>>> +++ b/hw/xen_backend.h
>>> @@ -5,6 +5,7 @@
>>> #include "sysemu.h"
>>> #include "net.h"
>>> #include "block_int.h"
>>> +#include "blockdev.h"
>>>
>>> /* ------------------------------------------------------------- */
>>
>> My bad. Thanks for fixing this! By the way, Is "block_int.h" really
>> needed here?
>
> Something else broke when I removed it, haven't looked at details though.
Just wondering because exposing block internals in another header file
is *not* nice.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] Re: [PATCH] xen: Fix build error due to missing include
2010-06-14 21:11 [Qemu-devel] [PATCH] xen: Fix build error due to missing include Jan Kiszka
2010-06-15 8:57 ` Markus Armbruster
@ 2010-06-15 9:00 ` Kevin Wolf
1 sibling, 0 replies; 5+ messages in thread
From: Kevin Wolf @ 2010-06-15 9:00 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Markus Armbruster, qemu-devel
Am 14.06.2010 23:11, schrieb Jan Kiszka:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-06-15 9:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-14 21:11 [Qemu-devel] [PATCH] xen: Fix build error due to missing include Jan Kiszka
2010-06-15 8:57 ` Markus Armbruster
2010-06-15 9:02 ` Jan Kiszka
2010-06-15 9:26 ` Markus Armbruster
2010-06-15 9:00 ` [Qemu-devel] " Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).