From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] block: fix a warning and possible truncation
Date: Tue, 15 Jun 2010 11:59:45 +0200 [thread overview]
Message-ID: <4C174F11.1000203@redhat.com> (raw)
In-Reply-To: <FEB87F7A-9ED0-4397-9055-5ECD19CF783B@suse.de>
Am 15.06.2010 11:52, schrieb Alexander Graf:
>
> Am 14.06.2010 um 20:55 schrieb Blue Swirl <blauwirbel@gmail.com>:
>
>> Fix a warning from OpenBSD gcc (3.3.5 (propolice)):
>> /src/qemu/block.c: In function `bdrv_info_stats_bs':
>> /src/qemu/block.c:1548: warning: long long int format, long unsigned
>> int arg (arg 6)
>>
>> There may be also truncation effects.
>>
>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>> ---
>> Alternatively 'ULL' prefix could be appended to BDRV_SECTOR_SIZE
>> definition but that may have other side effects.
>
> ... Which are probably wanted. If there are more truncations, we want
> to catch them early, no?
Actually, it's there:
#define BDRV_SECTOR_SIZE (1ULL << BDRV_SECTOR_BITS)
That compiler warning doesn't make any sense to me.
Kevin
prev parent reply other threads:[~2010-06-15 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 18:55 [Qemu-devel] [PATCH] block: fix a warning and possible truncation Blue Swirl
2010-06-15 7:52 ` [Qemu-devel] " Kevin Wolf
2010-06-15 8:08 ` Markus Armbruster
2010-06-15 9:52 ` [Qemu-devel] " Alexander Graf
2010-06-15 9:59 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C174F11.1000203@redhat.com \
--to=kwolf@redhat.com \
--cc=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).