From: Avi Kivity <avi@redhat.com>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target
Date: Tue, 15 Jun 2010 15:04:13 +0300 [thread overview]
Message-ID: <4C176C3D.5020103@redhat.com> (raw)
In-Reply-To: <1276599879-22749-1-git-send-email-Jes.Sorensen@redhat.com>
On 06/15/2010 02:04 PM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Hi,
>
> This set of patches fixes building qemu-kvm for non KVM targets, as
> reported in
> http://sourceforge.net/tracker/?func=detail&atid=893831&aid=2984626&group_id=180599
>
> One of the main problem is that we have a tendency to move things from
> Makefile.objs to Makefile.target in order to be able to use
> TARGET_I386 etc in hw/*.c files. IMHO we need to start clamping down
> on this harder and move things into separate files rather than the
> #ifdef hacks. Hence this patch fixes the short term problem, but there
> is more work to do for the longer term.
>
It's the other way round. Upstream keeps moving stuff out of
Makefile.target, and I move them back during merges, because the only
thing I can think of during a merge is "how quickly can I complete this
merge".
Thanks for tackling this.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-06-15 12:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 11:04 [Qemu-devel] [PATCH 0/7] Fix building qemu-kvm for non KVM target Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 1/7] Only call kvm_set_irqfd() if CONFIG_KVM is defined Jes.Sorensen
2010-06-15 13:31 ` [Qemu-devel] " Paolo Bonzini
2010-06-15 13:40 ` Jes Sorensen
2010-06-15 13:48 ` Paolo Bonzini
2010-06-15 14:58 ` Michael S. Tsirkin
2010-06-15 11:04 ` [Qemu-devel] [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h Jes.Sorensen
2010-06-15 13:34 ` [Qemu-devel] " Paolo Bonzini
2010-06-15 13:59 ` Jes Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 3/7] time_drift_fix is x86 only, rather than !ia64 Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 4/7] Build certain drivers for MIPS as well Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 5/7] Only export phys_mem create functions for !CONFIG_USER_ONLY builds Jes.Sorensen
2010-06-15 13:35 ` [Qemu-devel] " Paolo Bonzini
2010-06-15 11:04 ` [Qemu-devel] [PATCH 6/7] Only treat KVM specific cmdline options for KVM enabled builds Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 7/7] Only accept -no-hpet for i386 targets Jes.Sorensen
2010-06-15 12:20 ` [Qemu-devel] " Jan Kiszka
2010-06-15 12:28 ` Jes Sorensen
2010-06-15 12:37 ` Jan Kiszka
2010-06-15 12:44 ` Jes Sorensen
2010-06-15 13:38 ` Paolo Bonzini
2010-06-15 13:42 ` Jes Sorensen
2010-06-15 12:04 ` Avi Kivity [this message]
2010-06-15 12:06 ` [Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target Avi Kivity
2010-06-15 12:10 ` Jes Sorensen
2010-06-15 13:42 ` Juan Quintela
2010-06-15 13:44 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C176C3D.5020103@redhat.com \
--to=avi@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).