From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42644 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOUsL-0007DQ-7K for qemu-devel@nongnu.org; Tue, 15 Jun 2010 08:04:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOUsJ-0007cf-OH for qemu-devel@nongnu.org; Tue, 15 Jun 2010 08:04:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39171) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOUsJ-0007cY-GK for qemu-devel@nongnu.org; Tue, 15 Jun 2010 08:04:15 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5FC4Eiw013936 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 15 Jun 2010 08:04:14 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5FC4DxY011679 for ; Tue, 15 Jun 2010 08:04:14 -0400 Message-ID: <4C176C3D.5020103@redhat.com> Date: Tue, 15 Jun 2010 15:04:13 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1276599879-22749-1-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1276599879-22749-1-git-send-email-Jes.Sorensen@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes.Sorensen@redhat.com Cc: qemu-devel@nongnu.org On 06/15/2010 02:04 PM, Jes.Sorensen@redhat.com wrote: > From: Jes Sorensen > > Hi, > > This set of patches fixes building qemu-kvm for non KVM targets, as > reported in > http://sourceforge.net/tracker/?func=detail&atid=893831&aid=2984626&group_id=180599 > > One of the main problem is that we have a tendency to move things from > Makefile.objs to Makefile.target in order to be able to use > TARGET_I386 etc in hw/*.c files. IMHO we need to start clamping down > on this harder and move things into separate files rather than the > #ifdef hacks. Hence this patch fixes the short term problem, but there > is more work to do for the longer term. > It's the other way round. Upstream keeps moving stuff out of Makefile.target, and I move them back during merges, because the only thing I can think of during a merge is "how quickly can I complete this merge". Thanks for tackling this. -- error compiling committee.c: too many arguments to function