From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33321 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOUuQ-00010U-0M
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 08:06:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OOUuO-0007wb-31
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 08:06:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63305)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OOUuN-0007wU-RB
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 08:06:24 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5FC6MP4009524
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 15 Jun 2010 08:06:23 -0400
Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com
	[10.35.255.11])
	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id o5FC6Lb9017273
	for <qemu-devel@nongnu.org>; Tue, 15 Jun 2010 08:06:22 -0400
Message-ID: <4C176CBD.4080508@redhat.com>
Date: Tue, 15 Jun 2010 15:06:21 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1276599879-22749-1-git-send-email-Jes.Sorensen@redhat.com>
	<4C176C3D.5020103@redhat.com>
In-Reply-To: <4C176C3D.5020103@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM
	target
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org

On 06/15/2010 03:04 PM, Avi Kivity wrote:
> On 06/15/2010 02:04 PM, Jes.Sorensen@redhat.com wrote:
>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>> Hi,
>>
>> This set of patches fixes building qemu-kvm for non KVM targets, as
>> reported in
>> http://sourceforge.net/tracker/?func=detail&atid=893831&aid=2984626&group_id=180599 
>>
>>
>> One of the main problem is that we have a tendency to move things from
>> Makefile.objs to Makefile.target in order to be able to use
>> TARGET_I386 etc in hw/*.c files. IMHO we need to start clamping down
>> on this harder and move things into separate files rather than the
>> #ifdef hacks. Hence this patch fixes the short term problem, but there
>> is more work to do for the longer term.
>
> It's the other way round.  Upstream keeps moving stuff out of 
> Makefile.target, and I move them back during merges, because the only 
> thing I can think of during a merge is "how quickly can I complete 
> this merge".
>
> Thanks for tackling this.
>

Oh, I though you actually moved things back.

Anyway,

Reviewed-by: Avi Kivity <avi@redhat.com>


-- 
error compiling committee.c: too many arguments to function