qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target
Date: Tue, 15 Jun 2010 14:10:57 +0200	[thread overview]
Message-ID: <4C176DD1.2010605@redhat.com> (raw)
In-Reply-To: <4C176C3D.5020103@redhat.com>

On 06/15/10 14:04, Avi Kivity wrote:
> It's the other way round.  Upstream keeps moving stuff out of
> Makefile.target, and I move them back during merges, because the only
> thing I can think of during a merge is "how quickly can I complete this
> merge".
> 
> Thanks for tackling this.

I see. I found at least some of the cases I was tackling was because
things had moved from .objs to .target because of the TARGET_I386
checks. Trying to use TARGET_I386 in a file that is listed in
Makefile.objs causes nasty warnings.

I would very much like it if we can be more strict not allowing such
changes without a very strong reason in the future :)

Part of the problem is of course that there are no easy ways to check
for the presence of say HPET since we don't have CONFIG_HPET so
TARGET_I386 becomes the easy way :(

Cheers,
Jes

  parent reply	other threads:[~2010-06-15 12:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15 11:04 [Qemu-devel] [PATCH 0/7] Fix building qemu-kvm for non KVM target Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 1/7] Only call kvm_set_irqfd() if CONFIG_KVM is defined Jes.Sorensen
2010-06-15 13:31   ` [Qemu-devel] " Paolo Bonzini
2010-06-15 13:40     ` Jes Sorensen
2010-06-15 13:48       ` Paolo Bonzini
2010-06-15 14:58         ` Michael S. Tsirkin
2010-06-15 11:04 ` [Qemu-devel] [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h Jes.Sorensen
2010-06-15 13:34   ` [Qemu-devel] " Paolo Bonzini
2010-06-15 13:59     ` Jes Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 3/7] time_drift_fix is x86 only, rather than !ia64 Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 4/7] Build certain drivers for MIPS as well Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 5/7] Only export phys_mem create functions for !CONFIG_USER_ONLY builds Jes.Sorensen
2010-06-15 13:35   ` [Qemu-devel] " Paolo Bonzini
2010-06-15 11:04 ` [Qemu-devel] [PATCH 6/7] Only treat KVM specific cmdline options for KVM enabled builds Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 7/7] Only accept -no-hpet for i386 targets Jes.Sorensen
2010-06-15 12:20   ` [Qemu-devel] " Jan Kiszka
2010-06-15 12:28     ` Jes Sorensen
2010-06-15 12:37       ` Jan Kiszka
2010-06-15 12:44         ` Jes Sorensen
2010-06-15 13:38   ` Paolo Bonzini
2010-06-15 13:42     ` Jes Sorensen
2010-06-15 12:04 ` [Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target Avi Kivity
2010-06-15 12:06   ` Avi Kivity
2010-06-15 12:10   ` Jes Sorensen [this message]
2010-06-15 13:42     ` Juan Quintela
2010-06-15 13:44       ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C176DD1.2010605@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).