From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55121 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOVVk-000633-3v for qemu-devel@nongnu.org; Tue, 15 Jun 2010 08:45:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOVVi-0007AR-QI for qemu-devel@nongnu.org; Tue, 15 Jun 2010 08:44:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21456) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOVVi-0007AI-Je for qemu-devel@nongnu.org; Tue, 15 Jun 2010 08:44:58 -0400 Message-ID: <4C1775BF.4010404@redhat.com> Date: Tue, 15 Jun 2010 14:44:47 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1276599879-22749-1-git-send-email-Jes.Sorensen@redhat.com> <1276599879-22749-8-git-send-email-Jes.Sorensen@redhat.com> <4C177029.1090807@siemens.com> <4C1771F3.5090101@redhat.com> <4C1773FF.9030009@siemens.com> In-Reply-To: <4C1773FF.9030009@siemens.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 7/7] Only accept -no-hpet for i386 targets List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "avi@redhat.com" , "qemu-devel@nongnu.org" On 06/15/10 14:37, Jan Kiszka wrote: >> Upstream seems to have removed the TARGET_I386 around 'int no_hpet = 0;' >> but to be honest, I think the correct solution is to not expose no_hpet >> to non x86 targets in upstream. > > Then I would suggest to address this upstream first. The goal should be > to keep the diff low. I agree, I'll send out an updated diff in a minute to make qemu-kvm closer to qemu and then look at option exposure in qemu afterwards. Cheers, Jes