From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53919 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOWHg-0003qs-0C for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:34:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOWHZ-0007XM-TZ for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:34:27 -0400 Received: from mail-bw0-f45.google.com ([209.85.214.45]:37232) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOWHZ-0007XA-MZ for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:34:25 -0400 Received: by bwz9 with SMTP id 9so1867717bwz.4 for ; Tue, 15 Jun 2010 06:34:24 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4C17815D.4060102@redhat.com> Date: Tue, 15 Jun 2010 15:34:21 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1276599879-22749-1-git-send-email-Jes.Sorensen@redhat.com> <1276599879-22749-3-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1276599879-22749-3-git-send-email-Jes.Sorensen@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes.Sorensen@redhat.com Cc: avi@redhat.com, qemu-devel@nongnu.org On 06/15/2010 01:04 PM, Jes.Sorensen@redhat.com wrote: > From: Jes Sorensen > > No need for kvm_init() stub in kvm-stub.c as already defined in > qemu-kvm.h Why not keep the other one and match upstream? Instead, I'd remove this one and move kvm_inject_x86_mce to kvm-stub.c. Files that upstream compiles only once will be compiled only without CONFIG_KVM, and will always call the stubs if these are in qemu-kvm.h. Paolo