From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56014 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOWLd-0004oB-Fd
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:38:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OOWLT-0008As-Gy
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:38:28 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:57043)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OOWLT-0008Am-BD
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:38:27 -0400
Received: by bwz9 with SMTP id 9so1870375bwz.4
	for <qemu-devel@nongnu.org>; Tue, 15 Jun 2010 06:38:26 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4C17824E.8080509@redhat.com>
Date: Tue, 15 Jun 2010 15:38:22 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1276599879-22749-1-git-send-email-Jes.Sorensen@redhat.com>
	<1276599879-22749-8-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1276599879-22749-8-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 7/7] Only accept -no-hpet for i386 targets
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: avi@redhat.com, qemu-devel@nongnu.org

On 06/15/2010 01:04 PM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Only accept -no-hpet for i386 targets
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
> ---
>   vl.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index e4a9aa9..1977409 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3328,9 +3328,11 @@ int main(int argc, char **argv, char **envp)
>               case QEMU_OPTION_no_acpi:
>                   acpi_enabled = 0;
>                   break;
> +#ifdef TARGET_I386
>               case QEMU_OPTION_no_hpet:
>                   no_hpet = 1;
>                   break;
> +#endif
>               case QEMU_OPTION_balloon:
>                   if (balloon_parse(optarg)<  0) {
>                       fprintf(stderr, "Unknown -balloon argument %s\n", optarg);

This can alternatively be made to match upstream by just removing the 
#ifdef on no_hpet's declaration.

Not saying that -no-hpet makes any sense on non-i386 targets, mind, but 
it seems pointless to deviate from upstream.

Paolo