From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51664 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOWS3-0007GD-Gr for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:46:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOWRc-0000sT-Ii for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:44:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4607) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOWRc-0000sM-C4 for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:44:48 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5FDilxd031102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 15 Jun 2010 09:44:47 -0400 Message-ID: <4C1783C2.4090307@redhat.com> Date: Tue, 15 Jun 2010 15:44:34 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1276599879-22749-1-git-send-email-Jes.Sorensen@redhat.com> <4C176C3D.5020103@redhat.com> <4C176DD1.2010605@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Avi Kivity , qemu-devel@nongnu.org On 06/15/10 15:42, Juan Quintela wrote: > On my hpet removal patches, the important bit was that I enabled > #define CONFIG_HPET 1 > > in C land, that makes it easy to do this kind of tests. As it is today, > it is very difficult to test for a feature, as we only have TARGET_* > defines. > > Instead of CONFIG_HPET, we have TARGET_I386. I totally agree, and I'd like to see things like HPET becoming config options. Even for I386 builds, it may not be everybody who wants to build it in. Cheers, Jes