From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42501 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOWge-0006dP-3S
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 10:00:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OOWg2-00046B-H0
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:59:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11811)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OOWg2-000463-AM
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:59:42 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5FDxeut008848
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 15 Jun 2010 09:59:41 -0400
Message-ID: <4C17874A.6090002@redhat.com>
Date: Tue, 15 Jun 2010 15:59:38 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1276599879-22749-1-git-send-email-Jes.Sorensen@redhat.com>
	<1276599879-22749-3-git-send-email-Jes.Sorensen@redhat.com>
	<4C17815D.4060102@redhat.com>
In-Reply-To: <4C17815D.4060102@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/7] No need for kvm_init() stub as already
 defined in qemu-kvm.h
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: avi@redhat.com, qemu-devel@nongnu.org

On 06/15/10 15:34, Paolo Bonzini wrote:
> On 06/15/2010 01:04 PM, Jes.Sorensen@redhat.com wrote:
>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>> No need for kvm_init() stub in kvm-stub.c as already defined in
>> qemu-kvm.h
> 
> Why not keep the other one and match upstream?  Instead, I'd remove this
> one and move kvm_inject_x86_mce to kvm-stub.c.
> 
> Files that upstream compiles only once will be compiled only without
> CONFIG_KVM, and will always call the stubs if these are in qemu-kvm.h.

You're right, time for a v3 of the patch....

Cheers,
Jes