From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35051 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOXEY-0007kA-N4
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 10:35:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1OOXEW-0003Tc-G6
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 10:35:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7876)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1OOXEW-0003TN-6p
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 10:35:20 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5FEZJcF002575
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 15 Jun 2010 10:35:19 -0400
Message-ID: <4C178FA5.8080904@redhat.com>
Date: Tue, 15 Jun 2010 16:35:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1276612361-28604-1-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1276612361-28604-1-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3 0/7] Fix building qemu-kvm for non KVM
	target
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: mtosatti@redhat.com, qemu-devel@nongnu.org

On 06/15/2010 04:32 PM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Hi,
>
> This set of patches fixes building qemu-kvm for non KVM targets, as
> reported in
> http://sourceforge.net/tracker/?func=detail&atid=893831&aid=2984626&group_id=180599
>
> One of the main problem is that we have a tendency to move things from
> Makefile.objs to Makefile.target in order to be able to use
> TARGET_I386 etc in hw/*.c files. IMHO we need to start clamping down
> on this harder and move things into separate files rather than the
> #ifdef hacks. Hence this patch fixes the short term problem, but there
> is more work to do for the longer term.
>
> This version updates kvm_init() stub as pointed out by Paolo.

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo