From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39373 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOYna-0003Y7-4A for qemu-devel@nongnu.org; Tue, 15 Jun 2010 12:15:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOYlF-0004fT-5k for qemu-devel@nongnu.org; Tue, 15 Jun 2010 12:13:16 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:65216) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOYlF-0004fE-2f for qemu-devel@nongnu.org; Tue, 15 Jun 2010 12:13:13 -0400 Received: by iwn10 with SMTP id 10so5516598iwn.4 for ; Tue, 15 Jun 2010 09:13:11 -0700 (PDT) Message-ID: <4C17A6A0.2010203@codemonkey.ws> Date: Tue, 15 Jun 2010 11:13:20 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <20100615151812.GA24131@x200.localdomain> <20100615154153.GA2707@infradead.org> In-Reply-To: <20100615154153.GA2707@infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: KVM call minutes for June 15 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: Chris Wright , qemu-devel@nongnu.org, kvm@vger.kernel.org On 06/15/2010 10:41 AM, Christoph Hellwig wrote: > On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote: > >> KVM/qemu patches >> - patch rate is high, documentation is low, review is low >> - patches need to include better descriptions and documentation >> - will slow down patch writers >> - will make it easier for patch reviewers >> > What is the qemu patch review policy anyway? We don't really have a coherent policy. Suggestions for improvement are always appreciated. > There are no > "Reviewed-by:" included in the actual commits, Reviewed-by/Ack-by's are pretty helpful for me. In terms of including them in commit messages, if there's a strong feeling that that would be helpful then it's something I can look at doing but it also requires a fair bit of manual work during commit. > and the requirement > for a positive review also seem to vary a lot, up to the point that > some commiters commit code that has never hit a public mailing list > before. > That really shouldn't happen and if it does, please point it out on the list. Regards, Anthony Liguori > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >