From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41195 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOZFm-0006Of-J0
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 12:44:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OOZFl-0002ae-N4
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 12:44:46 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:62862)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OOZFl-0002aa-Jl
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 12:44:45 -0400
Received: by iwn10 with SMTP id 10so5545380iwn.4
	for <qemu-devel@nongnu.org>; Tue, 15 Jun 2010 09:44:45 -0700 (PDT)
Message-ID: <4C17AE0A.1010200@codemonkey.ws>
Date: Tue, 15 Jun 2010 11:44:58 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [CFR 2/10] qmp: block_passwd command
References: <1276619430-15871-1-git-send-email-aliguori@us.ibm.com>
	<1276619430-15871-3-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1276619430-15871-3-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>

On 06/15/2010 11:30 AM, Anthony Liguori wrote:
> block_passwd
> ------------
>    

I dislike abbreviations.  I also think that we should make commands 
verbs.  So I'd like to change the name to set_block_password and then we 
can alias block_passwd to that command if we need to.

> Set the password of encrypted block devices.
>
> Arguments:
>
> - "device": device name (json-string)
> - "password": password (json-string)
>    

What happens if:

1) device does not exist
2) media is not present
3) block format does not support encryption
4) password is invalid

Regards,

Anthony Liguori

> Example:
>
> ->  { "execute": "block_passwd", "arguments": { "device": "ide0-hd0",
>                                                 "password": "12345" } }
> <- { "return": {} }
>
>
>