From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40595 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOZJl-0008UA-Jb
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 12:48:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OOZJj-0003G1-Mm
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 12:48:53 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:45481)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OOZJj-0003FW-GQ
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 12:48:51 -0400
Received: by iwn10 with SMTP id 10so5548766iwn.4
	for <qemu-devel@nongnu.org>; Tue, 15 Jun 2010 09:48:50 -0700 (PDT)
Message-ID: <4C17AEFF.8000505@codemonkey.ws>
Date: Tue, 15 Jun 2010 11:49:03 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [CFR 8/10] device_add command
References: <1276619430-15871-1-git-send-email-aliguori@us.ibm.com>
	<1276619430-15871-9-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1276619430-15871-9-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>

On 06/15/2010 11:30 AM, Anthony Liguori wrote:
> device_add
> ----------
>
> Add a device.
>
> Arguments:
>
> - "driver": the name of the new device's driver (json-string)
>    

What class of name is this?  I believe this is a qdev name but the 
example is misleading because someone could reasonable do { "driver": 
"virtio", "id": "net1"}

> - "bus": the device's parent bus (device tree path, json-string, optional)
> - "id": the device's ID, must be unique (json-string)
> - device properties
>    

I think we need to document all of the supported devices and their 
properties as part of the spec.

What happens if we cannot add the device?  How does one use this for hot 
add?

Is the device available within the guest immediately after the 
device_add operation completes?

Regards,

Anthony Liguori

> Example:
>
> ->  { "execute": "device_add", "arguments": { "driver": "e1000", "id": "net1" } }
> <- { "return": {} }
>
> Notes:
>
> (1) For detailed information about this command, please refer to the
>      'docs/qdev-device-use.txt' file.
>
> (2) It's possible to list device properties by running QEMU with the
>      "-device DEVICE,\?" command-line argument, where DEVICE is the device's name
>
>