From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59753 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOZWw-0004P6-6o
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 13:02:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OOZWu-0005tY-R2
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 13:02:29 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:53695)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OOZWu-0005tT-O7
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 13:02:28 -0400
Received: by iwn10 with SMTP id 10so5560501iwn.4
	for <qemu-devel@nongnu.org>; Tue, 15 Jun 2010 10:02:28 -0700 (PDT)
Message-ID: <4C17B22D.1070804@codemonkey.ws>
Date: Tue, 15 Jun 2010 12:02:37 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [CFR 4/10] command
References: <1276619430-15871-1-git-send-email-aliguori@us.ibm.com>
	<1276619430-15871-5-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1276619430-15871-5-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>

On 06/15/2010 11:30 AM, Anthony Liguori wrote:
> change
> ------
>
> Change a removable medium or VNC configuration.
>    

I think this command is awkward and should be split into a change-media 
and change-vnc-password command.

> Arguments:
>
> - "device": device name (json-string)
> - "target": filename or item (json-string)
> - "arg": additional argument (json-string, optional)
>    

For change-media:

1) what happens if the drive does not support removable media?
2) what happens if the drive is locked?
3) what happens if media is not currently present?
4) what if I want to pass additional options to target like format=raw?
5) is the media change immediately present to the guest upon return of 
the command?

For change-vnc-password:

1) what if VNC is not in use?
2) what if I don't have vnc authentication enabled?
3) does changing the password have any affect on existing sessions?
4) is a new password required immediately after the command completes?

Regards,

Anthony Liguori

> Examples:
>
> 1. Change a removable medium
>
> ->  { "execute": "change",
>               "arguments": { "device": "ide1-cd0",
>                              "target": "/srv/images/Fedora-12-x86_64-DVD.iso" } }
> <- { "return": {} }
>
> 2. Change VNC password
>
> ->  { "execute": "change",
>               "arguments": { "device": "vnc", "target": "password",
>                              "arg": "foobar1" } }
> <- { "return": {} }
>
>
>