From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55502 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOdSY-0000rQ-2A for qemu-devel@nongnu.org; Tue, 15 Jun 2010 17:14:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOdSW-00081A-6Y for qemu-devel@nongnu.org; Tue, 15 Jun 2010 17:14:13 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:48841) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOdSW-00080l-4F for qemu-devel@nongnu.org; Tue, 15 Jun 2010 17:14:12 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e3.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o5FL0WIt026242 for ; Tue, 15 Jun 2010 17:00:32 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5FLE9kH103794 for ; Tue, 15 Jun 2010 17:14:09 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o5FLE8Ea013490 for ; Tue, 15 Jun 2010 17:14:09 -0400 Message-ID: <4C17ED2E.4020206@linux.vnet.ibm.com> Date: Tue, 15 Jun 2010 16:14:22 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [CFR 9/10] device_del command References: <1276619430-15871-1-git-send-email-aliguori@us.ibm.com> <1276619430-15871-10-git-send-email-aliguori@us.ibm.com> <4C17B181.8060008@siemens.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miguel Di Ciurcio Filho Cc: Anthony Liguori , Stefan Hajnoczi , Jan Kiszka , Markus Armbruster , qemu-devel@nongnu.org, Luiz Capitulino On 06/15/2010 03:48 PM, Miguel Di Ciurcio Filho wrote: > On Tue, Jun 15, 2010 at 1:59 PM, Jan Kiszka wrote: > >> Anthony Liguori wrote: >> >>> device_del >>> ---------- >>> >>> Remove a device. >>> >>> Arguments: >>> >>> - "id": the device's ID (json-string) >>> >> "id" should become "device" (I hope to send the corresponding patches >> this night). The idea is to not only allow global device IDs but also >> qtree paths here. >> >> > Now I'm confused. On a previous email when discussing about > query-netdev, I initially proposed this[1]: > > -> { "execute": "query-netdev" } > <- { > "return": [ > { > "device": "tap.0", > "vlan": 0, > "info": { > "script": "/etc/qemu-ifup", > "downscript": "/etc/qemu-ifdown", > "ifname": "tap0", > "model": "tap" > }, > }, > > And latter on Anthony suggested to replace "device" by "id" [2]. > > So my doubt is: we should identify guest/frontend devices in QMP using > the word "device" instead of "id" and identify backend devices by > using the word "id"? > id. What Jan is referring to is the qdev device path verses the qdev id. netdev objects are not qdev devices, they are just QemuOpts. In netdev parlance, the unique identifier is called the 'id'. Regards, Anthony Liguori > Regards, > > Miguel > > [1] http://lists.gnu.org/archive/html/qemu-devel/2010-06/msg00619.html > [2] http://lists.gnu.org/archive/html/qemu-devel/2010-06/msg00943.html >