qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Gleb Natapov <gleb@redhat.com>
Subject: [Qemu-devel] [PATCH] hpet: Clean up initial hpet counter
Date: Wed, 16 Jun 2010 00:40:28 +0200	[thread overview]
Message-ID: <4C18015C.1070306@web.de> (raw)

From: Jan Kiszka <jan.kiszka@siemens.com>

There is no need starting with the special value for hpet_cfg.count.
Either Seabios is aware of the new firmware interface and properly
interprets the counter or it simply ignores it anyway.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/hpet.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/hw/hpet.c b/hw/hpet.c
index d5c406c..ed4e995 100644
--- a/hw/hpet.c
+++ b/hw/hpet.c
@@ -74,7 +74,7 @@ typedef struct HPETState {
     uint8_t  hpet_id;           /* instance id */
 } HPETState;
 
-struct hpet_fw_config hpet_cfg = {.count = UINT8_MAX};
+struct hpet_fw_config hpet_cfg;
 
 static uint32_t hpet_in_legacy_mode(HPETState *s)
 {
@@ -682,11 +682,6 @@ static int hpet_init(SysBusDevice *dev)
     int i, iomemtype;
     HPETTimer *timer;
 
-    if (hpet_cfg.count == UINT8_MAX) {
-        /* first instance */
-        hpet_cfg.count = 0;
-    }
-
     if (hpet_cfg.count == 8) {
         fprintf(stderr, "Only 8 instances of HPET is allowed\n");
         return -1;
-- 
1.6.0.2

             reply	other threads:[~2010-06-15 22:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15 22:40 Jan Kiszka [this message]
2010-06-16  4:40 ` [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter Gleb Natapov
2010-06-16  7:03   ` Jan Kiszka
2010-06-16  7:33     ` Gleb Natapov
2010-06-16  7:51       ` Jan Kiszka
2010-06-16  7:52         ` Gleb Natapov
2010-06-16  7:57           ` Jan Kiszka
2010-06-16  9:06             ` Gleb Natapov
2010-06-16  9:33               ` Jan Kiszka
2010-06-16  9:35                 ` Gleb Natapov
2010-06-16 15:36                   ` Gleb Natapov
2010-06-16 16:00                     ` Jan Kiszka
2010-06-17  5:48                       ` Gleb Natapov
2010-06-17  7:17                         ` Jan Kiszka
2010-06-17  8:07                           ` Gleb Natapov
2010-06-17  8:30                             ` Jan Kiszka
2010-06-17  8:36                               ` Gleb Natapov
2010-06-17  8:42                                 ` Jan Kiszka
2010-06-17  8:46                                   ` Gleb Natapov
2010-06-17  8:59                                     ` Jan Kiszka
2010-06-17  9:01                                       ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C18015C.1070306@web.de \
    --to=jan.kiszka@web.de \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).