From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60775 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOnP5-0003Zn-Dq for qemu-devel@nongnu.org; Wed, 16 Jun 2010 03:51:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOnP4-0006W0-3j for qemu-devel@nongnu.org; Wed, 16 Jun 2010 03:51:19 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:40566) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOnP3-0006Vm-OT for qemu-devel@nongnu.org; Wed, 16 Jun 2010 03:51:18 -0400 Message-ID: <4C188272.9010201@web.de> Date: Wed, 16 Jun 2010 09:51:14 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4C18015C.1070306@web.de> <20100616044047.GF13238@redhat.com> <4C187725.2000902@web.de> <20100616073318.GZ21797@redhat.com> In-Reply-To: <20100616073318.GZ21797@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig25CB77327B2EFF2BE8D5D72A" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] hpet: Clean up initial hpet counter List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig25CB77327B2EFF2BE8D5D72A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Gleb Natapov wrote: > On Wed, Jun 16, 2010 at 09:03:01AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Wed, Jun 16, 2010 at 12:40:28AM +0200, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> There is no need starting with the special value for hpet_cfg.count.= >>>> Either Seabios is aware of the new firmware interface and properly >>>> interprets the counter or it simply ignores it anyway. >>>> >>> I want seabios to be able to distinguish between old qemu and new one= =2E >> I see now. But isn't it a good chance to introduce a proper generic >> interface for exploring supported fw-cfg keys? >> > Having such interface would be nice. Pity we haven't introduced it from= > the start. If we do it now seabios will have to find out somehow that > qemu support such interface. Chicken and egg ;) That is easy: Add a key the describes the highest supported key value (looks like this is monotonously increasing). Older qemu versions will return 0. Jan --------------enig25CB77327B2EFF2BE8D5D72A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkwYgnIACgkQitSsb3rl5xSJVACeMmMKzlfC416tp3jxEsJqQMvY xc0An2vWoqRfpNftM9axjxT1in0XY4Nx =QkoX -----END PGP SIGNATURE----- --------------enig25CB77327B2EFF2BE8D5D72A--