From: Kevin Wolf <kwolf@redhat.com>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices
Date: Wed, 16 Jun 2010 14:40:37 +0200 [thread overview]
Message-ID: <4C18C645.60200@redhat.com> (raw)
In-Reply-To: <1276653214-15427-1-git-send-email-miguel.filho@gmail.com>
Am 16.06.2010 03:53, schrieb Miguel Di Ciurcio Filho:
> The 'info snapshots' monitor command does not show snapshot information from all
> available block devices.
>
> Usage example:
> $ qemu -hda disk1.qcow2 -hdb disk2.qcow2
>
> (qemu) info snapshots
> Snapshot devices: ide0-hd0
> Snapshot list (from ide0-hd0):
> ID TAG VM SIZE DATE VM CLOCK
> 1 1.5M 2010-05-26 21:51:02 00:00:03.263
> 2 1.5M 2010-05-26 21:51:09 00:00:08.844
> 3 1.5M 2010-05-26 21:51:24 00:00:23.274
> 4 1.5M 2010-05-26 21:53:17 00:00:03.595
>
> In the above case, disk2.qcow2 has snapshot information, but it is not being
> shown. Only the first device is always shown.
>
> This patch updates the do_info_snapshots() function do correctly show snapshot
> information about all available block devices.
>
> New output:
> (qemu) info snapshots
> Snapshot list from ide0-hd0:
> ID TAG VM SIZE DATE VM CLOCK
> 1 1.5M 2010-05-26 21:51:02 00:00:03.263
> 2 1.5M 2010-05-26 21:51:09 00:00:08.844
> 3 1.5M 2010-05-26 21:51:24 00:00:23.274
> 4 1.5M 2010-05-26 21:53:17 00:00:03.595
>
> Snapshot list from ide0-hd1:
> ID TAG VM SIZE DATE VM CLOCK
> 1 0 2010-05-26 21:51:02 00:00:03.263
> 2 0 2010-05-26 21:51:09 00:00:08.844
> 3 0 2010-05-26 21:51:24 00:00:23.274
> 4 0 2010-05-26 21:53:17 00:00:03.595
>
> Signed-off-by: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
If the human monitor was exactly what its name says, I'd happily apply
this one (though I think it should be made clear from which image the VM
state would be loaded). However, it isn't and I'm not sure if this
wouldn't break libvirt. Dan, can you help?
If we can't change the info snapshots output, a possible alternative
would be to introduce another info command for this.
Kevin
next prev parent reply other threads:[~2010-06-16 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 1:53 [Qemu-devel] [PATCH] monitor: Really show snapshot information about all devices Miguel Di Ciurcio Filho
2010-06-16 12:40 ` Kevin Wolf [this message]
2010-06-16 12:59 ` [Qemu-devel] " Miguel Di Ciurcio Filho
2010-06-16 13:15 ` Kevin Wolf
[not found] ` <20100616152249.GB2835@localhost.localdomain>
2010-06-16 15:32 ` Kevin Wolf
[not found] ` <20100616155710.GC2835@localhost.localdomain>
2010-06-17 7:48 ` Kevin Wolf
2010-06-16 22:12 ` Miguel Di Ciurcio Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C18C645.60200@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=miguel.filho@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).