From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55219 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOsAA-0000if-VJ
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 08:56:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OOrvK-0001hI-MM
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 08:40:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46543)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OOrvK-0001gy-DW
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 08:40:54 -0400
Message-ID: <4C18C645.60200@redhat.com>
Date: Wed, 16 Jun 2010 14:40:37 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1276653214-15427-1-git-send-email-miguel.filho@gmail.com>
In-Reply-To: <1276653214-15427-1-git-send-email-miguel.filho@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information
	about all devices
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com

Am 16.06.2010 03:53, schrieb Miguel Di Ciurcio Filho:
> The 'info snapshots' monitor command does not show snapshot information from all
> available block devices.
> 
> Usage example:
> $ qemu -hda disk1.qcow2 -hdb disk2.qcow2
> 
> (qemu) info snapshots
> Snapshot devices: ide0-hd0
> Snapshot list (from ide0-hd0):
> ID        TAG                 VM SIZE                DATE       VM CLOCK
> 1                                1.5M 2010-05-26 21:51:02   00:00:03.263
> 2                                1.5M 2010-05-26 21:51:09   00:00:08.844
> 3                                1.5M 2010-05-26 21:51:24   00:00:23.274
> 4                                1.5M 2010-05-26 21:53:17   00:00:03.595
> 
> In the above case, disk2.qcow2 has snapshot information, but it is not being
> shown. Only the first device is always shown.
> 
> This patch updates the do_info_snapshots() function do correctly show snapshot
> information about all available block devices.
> 
> New output:
> (qemu) info snapshots
> Snapshot list from ide0-hd0:
> ID        TAG                 VM SIZE                DATE       VM CLOCK
> 1                                1.5M 2010-05-26 21:51:02   00:00:03.263
> 2                                1.5M 2010-05-26 21:51:09   00:00:08.844
> 3                                1.5M 2010-05-26 21:51:24   00:00:23.274
> 4                                1.5M 2010-05-26 21:53:17   00:00:03.595
> 
> Snapshot list from ide0-hd1:
> ID        TAG                 VM SIZE                DATE       VM CLOCK
> 1                                   0 2010-05-26 21:51:02   00:00:03.263
> 2                                   0 2010-05-26 21:51:09   00:00:08.844
> 3                                   0 2010-05-26 21:51:24   00:00:23.274
> 4                                   0 2010-05-26 21:53:17   00:00:03.595
> 
> Signed-off-by: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>

If the human monitor was exactly what its name says, I'd happily apply
this one (though I think it should be made clear from which image the VM
state would be loaded). However, it isn't and I'm not sure if this
wouldn't break libvirt. Dan, can you help?

If we can't change the info snapshots output, a possible alternative
would be to introduce another info command for this.

Kevin