From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40686 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOsSo-0005ah-H7
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:15:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OOsSm-0002fc-NL
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:15:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23177)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OOsSm-0002fU-EA
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:15:28 -0400
Message-ID: <4C18CE5F.3090402@redhat.com>
Date: Wed, 16 Jun 2010 15:15:11 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1276653214-15427-1-git-send-email-miguel.filho@gmail.com>	<4C18C645.60200@redhat.com>
	<AANLkTikVYbW4Bhqu9-8lAm66BuXWVWXf_nlzXNB0CFUC@mail.gmail.com>
In-Reply-To: <AANLkTikVYbW4Bhqu9-8lAm66BuXWVWXf_nlzXNB0CFUC@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information
 about all devices
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com

Am 16.06.2010 14:59, schrieb Miguel Di Ciurcio Filho:
> On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf <kwolf@redhat.com> wrote:
>>
>> If the human monitor was exactly what its name says, I'd happily apply
>> this one (though I think it should be made clear from which image the VM
>> state would be loaded). However, it isn't and I'm not sure if this
>> wouldn't break libvirt. Dan, can you help?
>>
> 
> I didn't mention in the commit, but I've looked at libvirt's source
> and it is not using 'info snapshots' AFAIK.

Anthony, Dan, are you okay with the change then?

> At the present time, the VM state is always saved in the first block
> device that supports snapshots. I could update the patch to make it
> clear on the output somehow.

Would be nice to make it clear. Something like this maybe:

    Snapshot list from ide0-hd0 (VM state image):
    [...]

Kevin