From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35300 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOslH-0002BT-Pg for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:34:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOslG-00070H-J6 for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:34:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45497) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOslG-0006zz-Aj for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:34:34 -0400 Message-ID: <4C18D29A.4040601@redhat.com> Date: Wed, 16 Jun 2010 15:33:14 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [CFR 2/10] qmp: block_passwd command References: <1276619430-15871-1-git-send-email-aliguori@us.ibm.com> <1276619430-15871-3-git-send-email-aliguori@us.ibm.com> <4C17AE0A.1010200@codemonkey.ws> In-Reply-To: <4C17AE0A.1010200@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Markus Armbruster , qemu-devel@nongnu.org, Stefan Hajnoczi , Luiz Capitulino Am 15.06.2010 18:44, schrieb Anthony Liguori: > On 06/15/2010 11:30 AM, Anthony Liguori wrote: >> block_passwd >> ------------ >> > > I dislike abbreviations. I also think that we should make commands > verbs. So I'd like to change the name to set_block_password and then we > can alias block_passwd to that command if we need to. Actually, I think this command should be removed and passwords should always be set as a blkdevice_add parameter when attaching an image. Your comments on error cases are still relevant for blockdev_add, of course. Kevin